fix(platform): Build failure in platform

DhairyaMajmudar commented 3 months ago

User description

Description

removing several build fails from platform app

Fixes #384

Dependencies

N/A

Future Improvements

There are still some build fails exist in the codebase

Mentions

@rajdip-b

Screenshots of relevant screens

N/A

Developer's checklist

[x] My PR follows the style guidelines of this project
[x] I have performed a self-check on my work

If changes are made in the code:

[x] I have followed the coding guidelines
[x] My changes in code generate no new warnings
[x] My changes are breaking another fix/feature of the project
[ ] I have added test cases to show that my feature works
[x] I have added relevant screenshots in my PR
[x] There are no UI/UX issues

Documentation Update

[ ] This PR requires an update to the documentation at docs.keyshade.xyz
[ ] I have made the necessary updates to the documentation, or no documentation changes are required.

PR Type

Bug fix, Enhancement

Description

Fixed the return type and response format in the health API route to ensure proper response handling.
Enhanced type safety and readability in the Command component by adding type annotations and removing unnecessary type assertions.

Changes walkthrough 📝

Relevant files

Bug fix

route.ts

Fix return type and response format in health API route

apps/platform/src/app/api/health/route.ts

Changed return type of GET function to NextResponse

Updated response format to JSON with status 200

+1/-1

Enhancement

command.tsx

Enhance type safety and readability in Command component

apps/platform/src/components/ui/command.tsx

Added type annotations for React.forwardRef components

Removed unnecessary type assertions

Improved type safety and readability

+30/-29

💡 PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

codiumai-pr-agent-free[bot] commented 3 months ago

Failed to generate code suggestions for PR

rajdip-b commented 3 months ago

@DhairyaMajmudar you can fix these one by one as time permits. We would be glad to have an error free code. Please ping @kriptonian1 in case you need some help since he is the code owner.

DhairyaMajmudar commented 3 months ago

Sure thing 🚀

kriptonian1 commented 3 months ago

Hey @DhairyaMajmudar this is issue are related to shadcn ui. So maybe you can refer to this issue https://github.com/shadcn-ui/ui/issues/3143 in which they have suggested a fix

DhairyaMajmudar commented 3 months ago

@kriptonian1 types failures are fixed, but still facing errors due to usage of locastorage in https://github.com/keyshade-xyz/keyshade/blob/develop/apps/platform/src/app/(main)/page.tsx#L60 and https://github.com/keyshade-xyz/keyshade/blob/develop/apps/platform/src/lib/workspace-storage.ts#L6 files, Below are the error logs:

platform:build: cache miss, executing 3caca622bba58b30
platform:build: 
platform:build: > platform@1.0.0 build /home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform
platform:build: > next build
platform:build: 
platform:build:  ✓ Creating an optimized production build 
platform:build:  ✓ Compiled successfully
platform:build:  ✓ Linting and checking validity of types 
platform:build:  ✓ Collecting page data 
   Generating static pages (0/11)  [=   ]ReferenceError: localStorage is not defined
platform:build:     at getCurrentWorkspace (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform/.next/server/chunks/159.js:1:8151)
platform:build:     at Combobox (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform/.next/server/chunks/159.js:1:9778)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:36421)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:49347)
platform:build:     at ny (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52524)
platform:build:     at nv (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at ng (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:54569)
platform:build:     at ny (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52770)
platform:build:     at nv (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:46622)
platform:build: 
platform:build: Error occurred prerendering page "/". Read more: https://nextjs.org/docs/messages/prerender-error
platform:build: ReferenceError: localStorage is not defined
platform:build:     at getCurrentWorkspace (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform/.next/server/chunks/159.js:1:8151)
platform:build:     at Combobox (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform/.next/server/chunks/159.js:1:9778)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:36421)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:49347)
platform:build:     at ny (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52524)
platform:build:     at nv (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at ng (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:54569)
platform:build:     at ny (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52770)
platform:build:     at nv (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:46622)
platform:build: ReferenceError: localStorage is not defined
platform:build:     at getCurrentWorkspace (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform/.next/server/chunks/159.js:1:8151)
platform:build:     at Combobox (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform/.next/server/chunks/159.js:1:9778)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:36421)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:49347)
platform:build:     at ny (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52524)
platform:build:     at nv (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at ng (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:54569)
platform:build:     at ny (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52770)
platform:build:     at nv (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:46622)
platform:build: 
platform:build: Error occurred prerendering page "/settings". Read more: https://nextjs.org/docs/messages/prerender-error
platform:build: ReferenceError: localStorage is not defined
platform:build:     at getCurrentWorkspace (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform/.next/server/chunks/159.js:1:8151)
platform:build:     at Combobox (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform/.next/server/chunks/159.js:1:9778)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:36421)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:49347)
platform:build:     at ny (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52524)
platform:build:     at nv (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at ng (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:54569)
platform:build:     at ny (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52770)
platform:build:     at nv (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:46622)
platform:build: ReferenceError: localStorage is not defined
platform:build:     at getCurrentWorkspace (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform/.next/server/chunks/159.js:1:8151)
platform:build:     at Combobox (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform/.next/server/chunks/159.js:1:9778)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:36421)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:49347)
platform:build:     at ny (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52524)
platform:build:     at nv (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at ng (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:54569)
platform:build:     at ny (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52770)
platform:build:     at nv (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:46622)
platform:build: 
platform:build: Error occurred prerendering page "/teams". Read more: https://nextjs.org/docs/messages/prerender-error
platform:build: ReferenceError: localStorage is not defined
platform:build:     at getCurrentWorkspace (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform/.next/server/chunks/159.js:1:8151)
platform:build:     at Combobox (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform/.next/server/chunks/159.js:1:9778)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:36421)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:49347)
platform:build:     at ny (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52524)
platform:build:     at nv (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at ng (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:54569)
platform:build:     at ny (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52770)
platform:build:     at nv (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:46622)
platform:build:  ✓ Generating static pages (11/11) 
platform:build: 
platform:build: > Export encountered errors on following paths:
platform:build:         /(main)/page: /
platform:build:         /(main)/settings/@billing/page: /settings
platform:build:         /(main)/teams/page: /teams
platform:build:  ELIFECYCLE  Command failed with exit code 1.
platform:build: ERROR: command finished with error: command (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform) /home/dhairya/.nvm/versions/node/v22.2.0/bin/pnpm run build exited (1)
platform#build: command (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform) /home/dhairya/.nvm/versions/node/v22.2.0/bin/pnpm run build exited (1)

 Tasks:    0 successful, 1 total
Cached:    0 cached, 1 total
  Time:    7.054s 
Failed:    platform#build

 ERROR  run failed: command  exited (1)
 ELIFECYCLE  Command failed with exit code 1.

cc: @rajdip-b

kriptonian1 commented 3 months ago

you can refer to this to fix it, but do give it a check if it is breaking something or not

DhairyaMajmudar commented 3 months ago

you can refer to this to fix it, but do give it a check if it is breaking something or not

* https://medium.com/@zamin_mirzad/how-to-fix-localstorage-is-not-defined-in-next-js-b237498d12ce

* https://sentry.io/answers/referenceerror-localstorage-is-not-defined-in-next-js/

* https://stackoverflow.com/questions/76070793/localstorage-is-not-defined-in-next-js

useEffect can be a solution but locastorage is used in utility files, so an alternative solution must be there to fix this

Let's merge this PR to fix other build errors. And do required changes to fix localstorage problem in another PR

codiumai-pr-agent-free[bot] commented 3 months ago

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review

Function Return Type
The function `GET` was changed from returning `unknown` to `NextResponse`. Ensure that this change aligns with the expected usage and does not introduce type mismatches elsewhere in the application. Type Annotations
Added type annotations and removed unnecessary type assertions in several components (`Command`, `CommandInput`, `CommandList`, `CommandEmpty`, `CommandGroup`, `CommandSeparator`, `CommandItem`). Review these changes for consistency and correctness of type usage.

codiumai-pr-agent-free[bot] commented 3 months ago

PR Code Suggestions ✨

Category	Suggestion	Score
Performance	Use memoization to improve component performance ___ Consider using memoization for the Command component to prevent unnecessary re-renders and improve performance. [apps/platform/src/components/ui/command.tsx [8-20]](https://github.com/keyshade-xyz/keyshade/pull/385/files#diff-f0016d0ae5f5903a2f29a5223ac6793ac18a55fbcb78c92f11a69c7c43c85499R8-R20) ```diff -const Command = React.forwardRef< +const Command = React.memo(React.forwardRef< React.ElementRef, React.ComponentPropsWithoutRef >(({ className, ...props }, ref) => ( -)) +))) ``` - [ ] Apply this suggestion Suggestion importance[1-10]: 9 Why: Using memoization can significantly improve performance by preventing unnecessary re-renders, which is particularly beneficial for frequently rendered components.	9
Best practice	Add explicit return type annotations to the function ___ Consider adding explicit type annotations for the return type of the `GET` function to enhance code readability and maintainability. [apps/platform/src/app/api/health/route.ts [3-5]](https://github.com/keyshade-xyz/keyshade/pull/385/files#diff-5832ee2be8237b91fd7053436a9016057e68473f3d403592234bbcd5fa7fea42R3-R5) ```diff +export function GET(): NextResponse { + return NextResponse.json({ message: 'Hello World' }, { status: 200 }) +} - ``` - [ ] Apply this suggestion Suggestion importance[1-10]: 8 Why: Adding explicit return type annotations improves code readability and maintainability, making it clear what the function is expected to return.	8
Possible bug	Ensure `className` is always a string ___ Ensure that the `className` prop is always defined as a string to avoid potential runtime errors or unexpected behaviors. [apps/platform/src/components/ui/command.tsx [12-19]](https://github.com/keyshade-xyz/keyshade/pull/385/files#diff-f0016d0ae5f5903a2f29a5223ac6793ac18a55fbcb78c92f11a69c7c43c85499R12-R19) ```diff ``` - [ ] Apply this suggestion Suggestion importance[1-10]: 7 Why: Ensuring that `className` is always a string can prevent potential runtime errors or unexpected behaviors, which is a good practice for robustness.	7
Enhancement	Use destructuring for props in the component ___ Use destructuring to handle props more cleanly in the component definition. [apps/platform/src/components/ui/command.tsx [8-20]](https://github.com/keyshade-xyz/keyshade/pull/385/files#diff-f0016d0ae5f5903a2f29a5223ac6793ac18a55fbcb78c92f11a69c7c43c85499R8-R20) ```diff ->(({ className, ...props }, ref) => ( +>(({ className, children, ...otherProps }, ref) => ( + {...otherProps} + > + {children} + )) ``` - [ ] Apply this suggestion Suggestion importance[1-10]: 6 Why: Using destructuring for props can make the code cleaner and more readable, but it is a minor enhancement and not crucial for functionality.	6

rajdip-b commented 3 months ago

you can refer to this to fix it, but do give it a check if it is breaking something or not
* https://medium.com/@zamin_mirzad/how-to-fix-localstorage-is-not-defined-in-next-js-b237498d12ce

* https://sentry.io/answers/referenceerror-localstorage-is-not-defined-in-next-js/

* https://stackoverflow.com/questions/76070793/localstorage-is-not-defined-in-next-js
useEffect can be a solution but locastorage is used in utility files, so an alternative solution must be there to fix this

Let's merge this PR to fix other build errors. And do required changes to fix localstorage problem in another PR

Thats good to hear! We will be using jotai anyways because of its clean API.

rajdip-b commented 3 months ago

pnpm build:platform

> keyshade-xyz@2.3.0 build:platform /home/raj/oss/keyshade.xyz/keyshade-xyz
> turbo run build --filter=platform

╭───────────────────────────────────────────────────────────────────────╮
│                                                                       │
│                  Update available v1.13.4 ≫ v2.0.12                   │
│    Changelog: https://github.com/vercel/turbo/releases/tag/v2.0.12    │
│           Run "npx @turbo/codemod@latest update" to update            │
│                                                                       │
│        Follow @turborepo for updates: https://x.com/turborepo         │
╰───────────────────────────────────────────────────────────────────────╯
• Packages in scope: platform
• Running build in 1 packages
• Remote caching disabled
platform:build: cache miss, executing b88efbf409a1557c
platform:build: 
platform:build: > platform@1.0.0 build /home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform
platform:build: > next build
platform:build: 
platform:build:  ✓ Creating an optimized production build 
platform:build:  ✓ Compiled successfully
platform:build:  ✓ Linting and checking validity of types 
platform:build:  ✓ Collecting page data 
   Generating static pages (0/11)  [=   ]ReferenceError: localStorage is not defined
platform:build:     at getCurrentWorkspace (/home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform/.next/server/chunks/935.js:1:8158)
platform:build:     at Combobox (/home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform/.next/server/chunks/935.js:1:9785)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:36421)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:49347)
platform:build:     at ny (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52524)
platform:build:     at nv (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at ng (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:54569)
platform:build:     at ny (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52770)
platform:build:     at nv (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:46622)
platform:build: 
platform:build: Error occurred prerendering page "/settings". Read more: https://nextjs.org/docs/messages/prerender-error
platform:build: ReferenceError: localStorage is not defined
platform:build:     at getCurrentWorkspace (/home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform/.next/server/chunks/935.js:1:8158)
platform:build:     at Combobox (/home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform/.next/server/chunks/935.js:1:9785)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:36421)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:49347)
platform:build:     at ny (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52524)
platform:build:     at nv (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at ng (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:54569)
platform:build:     at ny (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52770)
platform:build:     at nv (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:46622)
platform:build: ReferenceError: localStorage is not defined
platform:build:     at getCurrentWorkspace (/home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform/.next/server/chunks/935.js:1:8158)
platform:build:     at Combobox (/home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform/.next/server/chunks/935.js:1:9785)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:36421)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:49347)
platform:build:     at ny (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52524)
platform:build:     at nv (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at ng (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:54569)
platform:build:     at ny (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52770)
platform:build:     at nv (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:46622)
platform:build: 
platform:build: Error occurred prerendering page "/". Read more: https://nextjs.org/docs/messages/prerender-error
platform:build: ReferenceError: localStorage is not defined
platform:build:     at getCurrentWorkspace (/home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform/.next/server/chunks/935.js:1:8158)
platform:build:     at Combobox (/home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform/.next/server/chunks/935.js:1:9785)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:36421)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:49347)
platform:build:     at ny (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52524)
platform:build:     at nv (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at ng (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:54569)
platform:build:     at ny (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52770)
platform:build:     at nv (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:46622)
platform:build: ReferenceError: localStorage is not defined
platform:build:     at getCurrentWorkspace (/home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform/.next/server/chunks/935.js:1:8158)
platform:build:     at Combobox (/home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform/.next/server/chunks/935.js:1:9785)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:36421)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:49347)
platform:build:     at ny (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52524)
platform:build:     at nv (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at ng (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:54569)
platform:build:     at ny (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52770)
platform:build:     at nv (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:46622)
platform:build: 
platform:build: Error occurred prerendering page "/teams". Read more: https://nextjs.org/docs/messages/prerender-error
platform:build: ReferenceError: localStorage is not defined
platform:build:     at getCurrentWorkspace (/home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform/.next/server/chunks/935.js:1:8158)
platform:build:     at Combobox (/home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform/.next/server/chunks/935.js:1:9785)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:36421)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:49347)
platform:build:     at ny (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52524)
platform:build:     at nv (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at ng (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:54569)
platform:build:     at ny (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52770)
platform:build:     at nv (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:46622)
platform:build:  ✓ Generating static pages (11/11) 
platform:build: 
platform:build: > Export encountered errors on following paths:
platform:build:     /(main)/page: /
platform:build:     /(main)/settings/@profile/page: /settings
platform:build:     /(main)/teams/page: /teams
platform:build:  ELIFECYCLE  Command failed with exit code 1.
platform:build: ERROR: command finished with error: command (/home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform) /home/raj/.local/share/pnpm/pnpm run build exited (1)
platform#build: command (/home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform) /home/raj/.local/share/pnpm/pnpm run build exited (1)

 Tasks:    0 successful, 1 total
Cached:    0 cached, 1 total
  Time:    35.529s 
Failed:    platform#build

 ERROR  run failed: command  exited (1)
 ELIFECYCLE  Command failed with exit code 1.

I got this error @DhairyaMajmudar. Any ideas what might be causing it?

P.S. can we swap out jotai with local storage? I don't think it makes sense to store workspace data in local storage since we need to add an observer to that. @kriptonian1

rajdip-b commented 2 months ago

@DhairyaMajmudar hey bro! Long time since you have put this up. Do we have any changes?

DhairyaMajmudar commented 2 months ago

Hi I've suggested a fix for this here https://github.com/keyshade-xyz/keyshade/pull/385#issuecomment-2278002809

rajdip-b commented 2 months ago

Moving this convo to discord! I'm still seeing a few errors.

rajdip-b commented 2 months ago

Merging this for now, the persisting error needs to swap out local storage with Jotai

keyshade-xyz / keyshade