keyshade-xyz / keyshade

Realtime secret and configuration management tool, with the best in class security and seamless integration support
https://keyshade.xyz
Mozilla Public License 2.0
208 stars 105 forks source link

API: Display membership status while fetching workspace members #406

Open rajdip-b opened 3 months ago

rajdip-b commented 3 months ago

Description

When we hit the /api/workspace/{workspaceId}/members endpoint to fetch all the members of a workspace, we also want to get the membership status of the member, i.e, if they have accepted the invitation or not.

Currently, we just get the id, user and the roles they have. image

Solution

We would want the return type to also include a active field that will be true if the user has accepted the invitation, false otherwise.

lakshay-saini-au8 commented 3 months ago

/attempt

github-actions[bot] commented 3 months ago

Assigned the issue to @lakshay-saini-au8!

lakshay-saini-au8 commented 3 months ago

@rajdip-b if possible can you share what will be the expected response

lakshay-saini-au8 commented 3 months ago

is it like

`{ id : "", type:{active:}, user:{}

`

rajdip-b commented 2 months ago

Hey @lakshay-saini-au8! Sorry about the late reply, must have overlooked your comments.

We just want something like this:

{
  // ...other fields,
  membershipAccepted: true/false
}
rajdip-b commented 2 months ago

@lakshay-saini-au8 any updates on this yet?

rothardo commented 1 month ago

Hi @rajdip-b I would like to work on this issue as I think this is pending since more then 12 weeks, please let me know if this is up for grabs

rajdip-b commented 1 month ago

Sure, do go ahead!

rothardo commented 3 weeks ago

Hi @rajdip-b ,

I hope you're doing well. I've been working on setting up the project according to the guidelines, but I've encountered a problem that's been quite bothersome.

I've followed the recommendations regarding PostgreSQL issues, and while I'm using WSL, which has been consuming a lot of memory, I’m managing that.

However, I would really appreciate your help in resolving the issue shown below so I can move forward:

Screenshot 2024-10-22 191849

Thank you!

rajdip-b commented 3 weeks ago

Hey, can you please open up a github discussion for this issue? I feel that a lot of people will benefit from that. We are facing this issue quite often.

rothardo commented 3 weeks ago

@rajdip-b I have opened a discussion on the same, thank you

rothardo commented 2 weeks ago

Hi there! I’m having trouble with the login process, and the documentation isn’t very clear about which modules to run. Could you guide me on how to run the project in full-stack mode? The backend is up and running, but I’m not sure where to find the UI or which directory to check. Thanks! @rajdip-b

rajdip-b commented 2 weeks ago

The UI is still under works. The designs are incomplete. All of the api dev is currently being done using postman. So it's pointless in running the UI since it can only do so much. I recommend you to go through the postman api docs. You can find the link in readme.

rajdip-b commented 1 week ago

@rothardo any luck?

rothardo commented 1 week ago

@rajdip-b yes, will raise pr soon

rajdip-b commented 1 week ago

Looking forward to it!