search

keyshade-xyz / keyshade

Realtime secret and configuration management tool, with the best in class security and seamless integration support
https://keyshade.xyz
Mozilla Public License 2.0
196 stars 96 forks source link

PLATFORM: Test failing due to strict null check implementation #412

Closed unamdev0 closed 3 weeks ago

unamdev0 commented 3 weeks ago

Describe the bug Tests are failing due to strict null check implementation done in this commit

To Reproduce Run pnpm run test

Expected behavior All tests should pass successfully

Screenshots

Screenshot 2024-09-06 at 7 07 51 PM
rajdip-b commented 3 weeks ago

Hi! Thanks for opening this issue! We have a LOT of inconsistencies across our platform package since it's not yet actively developed.

We have quite a few errors in this package. Would be very glad if you can come up with the fixes!

unamdev0 commented 3 weeks ago

Gladly, my solution would be to apply optional chaining for the time being at all these critical places,but since that's what was there before and was removed, can you please suggest any other solution which can be done

rajdip-b commented 3 weeks ago

Gladly, my solution would be to apply optional chaining for the time being at all these critical places,but since that's what was there before and was removed, can you please suggest any other solution which can be done

I think pretty much any changes that I made were to make sure the lints passed back then. So if bringing them back helps preventing this issue, I would be glad to accept the solution.

unamdev0 commented 3 weeks ago

Cool, making the required changes

unamdev0 commented 3 weeks ago

/attempt

github-actions[bot] commented 3 weeks ago

Assigned the issue to @unamdev0!

rajdip-b commented 2 weeks ago

:tada: This issue has been resolved in version 2.5.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: