search

keyshade-xyz / keyshade

Realtime secret and configuration management tool, with the best in class security and seamless integration support
https://keyshade.xyz
Mozilla Public License 2.0
208 stars 105 forks source link

WEB: Website logo cut off or overlaps in footer #433

Closed AadiVerma closed 2 months ago

AadiVerma commented 2 months ago

Describe the bug The website name is either partially displayed or gets overridden by other elements in the footer section

To Reproduce Steps to reproduce the behavior:

  1. Open the website
  2. Scroll down to the footer section.
  3. Observe that the website name is cut off or overlaps with other footer content.

Expected behavior The website name should be fully visible in the footer section without being truncated or overridden, regardless of screen size.

Screenshots Screenshot 2024-09-15 132849

rajdip-b commented 2 months ago

Hmm, looks legit. Would you be able to come up with a fix?

AadiVerma commented 2 months ago

Hmm, looks legit. Would you be able to come up with a fix?

I can definitely try.

m7md-Y-3mra commented 2 months ago

Hi @AadiVerma @rajdip-b,

I've reviewed the issue and would like to work on fixing it. Please assign it to me, and I'll start by ensuring the website name is fully visible in the footer without being cut off or overlapping with other elements, regardless of screen size.

Looking forward to contributing!

Thanks.

rajdip-b commented 2 months ago

Ah boy, in this case I'm not sure whom I should assign this to. Needless to say there isn't any competition. I would recommend you folks to have a chat among yourself and decode who gets to implement it.

AadiVerma commented 2 months ago

Np, I have no issues he can continue

m7md-Y-3mra commented 2 months ago

Hi @rajdip-b,

I've resolved the issue with the footer where the website name was cut off or overlapping with other elements. However, I've noticed a new issue with horizontal scrolling on the website.

Should I proceed with investigating and fixing the horizontal scroll issue, or would you prefer to handle it differently?

Looking forward to your guidance!

Thanks.

rajdip-b commented 2 months ago

You can raise a new issue about it and self assign yourself. It helps us in keeping track of things!

m7md-Y-3mra commented 2 months ago

I've created a new issue for the horizontal scrolling problem: https://github.com/keyshade-xyz/keyshade/issues/437

Could you please assign it to me?

rajdip-b commented 2 months ago

Hey @m7md-Y-3mra, unfortunately someone just started attempting that. I won't be able to unassign them. From the next issues onwards, you would just need to comment /attempt on the issue description and you will be auto assigned!

m7md-Y-3mra commented 2 months ago

@rajdip-b Hi I did the PR #444 . If there is anything then let me know. Thanks

AadiVerma commented 2 months ago

Still Logo is cut off image

rajdip-b commented 3 weeks ago

:tada: This issue has been resolved in version 2.6.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: