keyshade-xyz / keyshade

Realtime secret and configuration management tool, with the best in class security and seamless integration support
https://keyshade.xyz
Mozilla Public License 2.0
208 stars 105 forks source link

fix(platform): Fixed duplicate Google Logo UI fix #450

Closed prabuddha369 closed 2 months ago

prabuddha369 commented 2 months ago

User description

Description

image Added Gitlab logo

Fixes #449

Dependencies

NA

Future Improvements

Linking to the Backend and if i get the figma file , i can add more features !

Mentions

@rajdip-b

Screenshots of relevant screens

image

Developer's checklist

If changes are made in the code:

Documentation Update


PR Type

Enhancement, Other


Description


Changes walkthrough πŸ“

Relevant files
Formatting
50 files
grafana.ts
Code formatting and consistency improvements in Grafana rules.

packages/secret-scan/src/rules/grafana.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • Added missing newline at the end of the file.
  • +82/-75 
    authress.ts
    Code formatting and consistency improvements in Authress rules.

    packages/secret-scan/src/rules/authress.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • Added missing newline at the end of the file.
  • +95/-85 
    cloudflare.ts
    Code formatting and consistency improvements in Cloudflare rules.

    packages/secret-scan/src/rules/cloudflare.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • Added missing newline at the end of the file.
  • +62/-59 
    bitbucket.ts
    Code formatting and consistency improvements in Bitbucket rules.

    packages/secret-scan/src/rules/bitbucket.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • +24/-18 
    facebook.ts
    Code formatting and consistency improvements in Facebook rules.

    packages/secret-scan/src/rules/facebook.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • +44/-42 
    confluent.ts
    Code formatting and consistency improvements in Confluent rules.

    packages/secret-scan/src/rules/confluent.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • Added missing newline at the end of the file.
  • +50/-46 
    atlassian.ts
    Code formatting and consistency improvements in Atlassian rules.

    packages/secret-scan/src/rules/atlassian.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • +56/-56 
    shopify.ts
    Code formatting and consistency improvements in Shopify rules.

    packages/secret-scan/src/rules/shopify.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • Added missing newline at the end of the file.
  • +44/-44 
    harness.ts
    Code formatting and consistency improvements in Harness rules.

    packages/secret-scan/src/rules/harness.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • Added missing newline at the end of the file.
  • +46/-42 
    planetscale.ts
    Code formatting and consistency improvements in Planetscale rules.

    packages/secret-scan/src/rules/planetscale.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • Added missing newline at the end of the file.
  • +35/-34 
    dropbox.ts
    Code formatting and consistency improvements in Dropbox rules.

    packages/secret-scan/src/rules/dropbox.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • Added missing newline at the end of the file.
  • +36/-35 
    dynatrace.ts
    Code formatting and consistency improvements in Dynatrace rules.

    packages/secret-scan/src/rules/dynatrace.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • Added missing newline at the end of the file.
  • +36/-33 
    digitalocean.ts
    Code formatting and consistency improvements in DigitalOcean rules.

    packages/secret-scan/src/rules/digitalocean.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • Added missing newline at the end of the file.
  • +38/-35 
    definednetworking.ts
    Code formatting and consistency improvements in Defined Networking
    rules.

    packages/secret-scan/src/rules/definednetworking.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • Added missing newline at the end of the file.
  • +37/-34 
    sidekiq.ts
    Code formatting and consistency improvements in Sidekiq rules.

    packages/secret-scan/src/rules/sidekiq.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • Added missing newline at the end of the file.
  • +25/-24 
    intra42.ts
    Code formatting and consistency improvements in Intra42 rules.

    packages/secret-scan/src/rules/intra42.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • Added missing newline at the end of the file.
  • +33/-30 
    huggingface.ts
    Code formatting and consistency improvements in Huggingface rules.

    packages/secret-scan/src/rules/huggingface.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • Added missing newline at the end of the file.
  • +32/-32 
    gitlab.ts
    Code formatting and consistency improvements in GitLab rules.

    packages/secret-scan/src/rules/gitlab.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • Added missing newline at the end of the file.
  • +39/-39 
    heroku.ts
    Code formatting and consistency improvements in Heroku rules.

    packages/secret-scan/src/rules/heroku.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • Added missing newline at the end of the file.
  • +30/-30 
    coinbase.ts
    Code formatting and consistency improvements in Coinbase rules.

    packages/secret-scan/src/rules/coinbase.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • Added missing newline at the end of the file.
  • +30/-29 
    frameio.ts
    Code formatting and consistency improvements in FrameIO rules.

    packages/secret-scan/src/rules/frameio.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • Added missing newline at the end of the file.
  • +36/-33 
    hubspot.ts
    Code formatting and consistency improvements in HubSpot rules.

    packages/secret-scan/src/rules/hubspot.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • Added missing newline at the end of the file.
  • +30/-30 
    easypost.ts
    Code formatting and consistency improvements in EasyPost rules.

    packages/secret-scan/src/rules/easypost.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • Added missing newline at the end of the file.
  • +34/-34 
    clojars.ts
    Code formatting and consistency improvements in Clojars rules.

    packages/secret-scan/src/rules/clojars.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • Added missing newline at the end of the file.
  • +32/-29 
    flutterwave.ts
    Code formatting and consistency improvements in Flutterwave rules.

    packages/secret-scan/src/rules/flutterwave.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • Added missing newline at the end of the file.
  • +31/-31 
    contentful.ts
    Code formatting and consistency improvements in Contentful rules.

    packages/secret-scan/src/rules/contentful.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • Added missing newline at the end of the file.
  • +30/-30 
    beamer.ts
    Code formatting and consistency improvements in Beamer rules.

    packages/secret-scan/src/rules/beamer.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • Added missing newline at the end of the file.
  • +29/-29 
    doppler.ts
    Code formatting and consistency improvements in Doppler rules.

    packages/secret-scan/src/rules/doppler.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • Added missing newline at the end of the file.
  • +33/-33 
    duffel.ts
    Code formatting and consistency improvements in Duffel rules.

    packages/secret-scan/src/rules/duffel.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • Added missing newline at the end of the file.
  • +33/-33 
    datadog.ts
    Code formatting and consistency improvements in Datadog rules.

    packages/secret-scan/src/rules/datadog.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • Added missing newline at the end of the file.
  • +30/-30 
    lob.ts
    Code formatting and consistency improvements in Lob rules.

    packages/secret-scan/src/rules/lob.ts
  • Adjusted indentation for better readability.
  • Reformatted test case inputs for consistency.
  • Added missing newline at the end of the file.
  • +30/-30 
    airtable.ts
    Added newline for consistency in Airtable rules.                 

    packages/secret-scan/src/rules/airtable.ts - Added missing newline at the end of the file.
    +1/-1     
    sendinblue.ts
    Code formatting improvements for Sendinblue rule file.     

    packages/secret-scan/src/rules/sendinblue.ts
  • Fixed spacing issues in import statements.
  • Adjusted indentation for better readability.
  • +24/-22 
    hashicorp.ts
    Code formatting improvements for Hashicorp rule file.       

    packages/secret-scan/src/rules/hashicorp.ts
  • Fixed spacing issues in import statements.
  • Adjusted indentation for better readability.
  • +20/-18 
    databricks.ts
    Code formatting improvements for Databricks rule file.     

    packages/secret-scan/src/rules/databricks.ts
  • Fixed spacing issues in import statements.
  • Adjusted indentation for better readability.
  • +30/-30 
    index.ts
    Standardized import statement quotes in index file.           

    packages/secret-scan/src/rules/index.ts - Changed double quotes to single quotes in import statements.
    +21/-21 
    age.ts
    Code formatting improvements for Age rule file.                   

    packages/secret-scan/src/rules/age.ts - Adjusted indentation for better readability.
    +7/-5     
    readme.ts
    Code formatting improvements for Readme rule file.             

    packages/secret-scan/src/rules/readme.ts
  • Fixed spacing issues in import statements.
  • Adjusted indentation for better readability.
  • +24/-22 
    postman.ts
    Code formatting improvements for Postman rule file.           

    packages/secret-scan/src/rules/postman.ts
  • Fixed spacing issues in import statements.
  • Adjusted indentation for better readability.
  • +22/-22 
    scalingo.ts
    Code formatting improvements for Scalingo rule file.         

    packages/secret-scan/src/rules/scalingo.ts
  • Fixed spacing issues in import statements.
  • Adjusted indentation for better readability.
  • +22/-22 
    linear.ts
    Code formatting improvements for Linear rule file.             

    packages/secret-scan/src/rules/linear.ts
  • Fixed spacing issues in import statements.
  • Adjusted indentation for better readability.
  • +22/-22 
    infracost.ts
    Code formatting improvements for Infracost rule file.       

    packages/secret-scan/src/rules/infracost.ts
  • Fixed spacing issues in import statements.
  • Adjusted indentation for better readability.
  • +22/-22 
    rubygems.ts
    Code formatting improvements for Rubygems rule file.         

    packages/secret-scan/src/rules/rubygems.ts
  • Fixed spacing issues in import statements.
  • Adjusted indentation for better readability.
  • +22/-22 
    asana.ts
    Code formatting improvements for Asana rule file.               

    packages/secret-scan/src/rules/asana.ts - Adjusted indentation for better readability.
    +24/-24 
    prefect.ts
    Code formatting improvements for Prefect rule file.           

    packages/secret-scan/src/rules/prefect.ts
  • Fixed spacing issues in import statements.
  • Adjusted indentation for better readability.
  • +22/-22 
    pulumi.ts
    Code formatting improvements for Pulumi rule file.             

    packages/secret-scan/src/rules/pulumi.ts
  • Fixed spacing issues in import statements.
  • Adjusted indentation for better readability.
  • +22/-22 
    shippo.ts
    Code formatting improvements for Shippo rule file.             

    packages/secret-scan/src/rules/shippo.ts
  • Fixed spacing issues in import statements.
  • Adjusted indentation for better readability.
  • +22/-22 
    codecov.ts
    Code formatting improvements for Codecov rule file.           

    packages/secret-scan/src/rules/codecov.ts
  • Fixed spacing issues in import statements.
  • Adjusted indentation for better readability.
  • +6/-6     
    bittrex.ts
    Code formatting improvements for Bittrex rule file.           

    packages/secret-scan/src/rules/bittrex.ts - Adjusted indentation for better readability.
    +4/-4     
    page.tsx
    Reordered imports in career page component.                           

    apps/web/src/app/(main)/career/page.tsx - Reordered imports for consistency.
    +1/-1     
    Enhancement
    2 files
    page.tsx
    Added Gitlab logo to authentication page.                               

    apps/platform/src/app/auth/page.tsx
  • Added import for GitlabSVG.
  • Replaced GoogleSVG with GitlabSVG in the button component.
  • +7/-2     
    index.ts
    Exported GitlabSVG from auth SVG index.                                   

    apps/platform/public/svg/auth/index.ts - Added GitlabSVG to the exports.
    +2/-1     

    πŸ’‘ PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    codiumai-pr-agent-free[bot] commented 2 months ago

    PR Reviewer Guide πŸ”

    ⏱️ Estimated effort to review: 2 πŸ”΅πŸ”΅βšͺβšͺβšͺ
    πŸ§ͺ No relevant tests
    πŸ”’ No security concerns identified
    ⚑ Key issues to review

    Code Formatting
    The code has been reformatted with improved indentation and spacing. While this improves readability, it's important to ensure that these changes are consistent with the project's coding standards. Import Order
    The order of imports has been changed and new imports have been added. It's important to verify that this new order doesn't break any existing functionality and follows the project's import conventions.
    codiumai-pr-agent-free[bot] commented 2 months ago

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Enhancement
    Add a negative test case to verify length constraint handling in the regex ___ **Consider adding a negative test case for an input that starts with one of the valid
    prefixes but doesn't meet the length requirement. This would help ensure the regex
    is correctly handling the length constraint.** [packages/secret-scan/src/rules/atlassian.ts [11-22]](https://github.com/keyshade-xyz/keyshade/pull/450/files#diff-19008ff82781cedbe44d0cb36b70dbf0bd79fa3c6de3757838723de50df94ca7R11-R22) ```diff const testcase: TestCase[] = [ { input: 'confluenceojqhLdXTkuq6evzHPAxG4Gec', expected: true }, { input: 'jirai2rfog2lrLrchssWRvvqcAak', expected: true }, { input: 'jiraStCBHh8bkPREl880xgj2c5Pr', expected: true }, + { + input: 'atlassianABC123', // 24 characters, but too short + expected: false + }, ``` - [ ] **Apply this suggestion**
    Suggestion importance[1-10]: 8 Why: Adding a negative test case for inputs that start with valid prefixes but do not meet the length requirement enhances the robustness of the test suite by ensuring the regex correctly enforces length constraints.
    8
    Best practice
    Rename the test case variable to be more specific and descriptive ___ **Consider using a more descriptive variable name instead of testcase. For example,
    grafanaTestCases would be more specific and aligned with the function name.** [packages/secret-scan/src/rules/grafana.ts [12]](https://github.com/keyshade-xyz/keyshade/pull/450/files#diff-b7240dca100482b67c561336d4044ba4c4995bcdc9ec72f3fdf7280ed01f431bR12-R12) ```diff -const testcase: TestCase[] = [ +const grafanaTestCases: TestCase[] = [ ``` - [ ] **Apply this suggestion**
    Suggestion importance[1-10]: 7 Why: The suggestion to rename the variable `testcase` to `grafanaTestCases` improves code readability and maintainability by making the variable name more descriptive and aligned with the function it is associated with. This is a minor improvement but follows best practices for naming conventions.
    7
    Improve variable naming for better code readability and maintainability ___ **Consider using a more descriptive variable name instead of testcase. For example,
    facebookTestCases would be more specific and align with the function name.** [packages/secret-scan/src/rules/facebook.ts [11]](https://github.com/keyshade-xyz/keyshade/pull/450/files#diff-4f5ef62e2dc7c7df22e7536e3125b5c8031184fc29727a4b7fdbb7580dd37f35R11-R11) ```diff -const testcase: TestCase[] = [ +const facebookTestCases: TestCase[] = [ ``` - [ ] **Apply this suggestion**
    Suggestion importance[1-10]: 7 Why: The suggestion to rename `testcase` to `facebookTestCases` improves code readability and maintainability by making the variable name more descriptive and aligned with the function it is associated with.
    7
    βœ… Group and sort imports alphabetically for better organization ___
    Suggestion Impact:The imports were reordered alphabetically, including the addition of 'algolia' and 'alibaba', which aligns with the suggestion to organize imports alphabetically. code diff: ```diff import algolia from './algolia' import alibaba from './alibaba' -import adafruit from './adafruit' -import adobe from './adobe' -import age from './age' -import airtable from './airtable' -import asana from './asana' -import atlassian from './atlassian' -import authress from './authress' -import beamer from './beamer' -import bitbucket from './bitbucket' -import bittrex from './bittrex' +import adafruit from "./adafruit" +import adobe from "./adobe" +import age from "./age" +import airtable from "./airtable" +import asana from "./asana" +import atlassian from "./atlassian" +import authress from "./authress" +import beamer from "./beamer" +import bitbucket from "./bitbucket" +import bittrex from "./bittrex" ```
    ___ **Consider grouping related imports together and sorting them alphabetically for
    better organization and readability.** [packages/secret-scan/src/rules/index.ts [19-28]](https://github.com/keyshade-xyz/keyshade/pull/450/files#diff-a4644762648cb920b1cdc950b7d88cfbc45c82c768f751506c2b1484b896dd84R19-R28) ```diff import adafruit from './adafruit' import adobe from './adobe' import age from './age' import airtable from './airtable' +import alibaba from './alibaba' +import algolia from './algolia' +import artifactory from './artifactory' import asana from './asana' import atlassian from './atlassian' import authress from './authress' -import beamer from './beamer' -import bitbucket from './bitbucket' -import bittrex from './bittrex' ``` - [ ] **Apply this suggestion**
    Suggestion importance[1-10]: 7 Why: The suggestion to group and sort imports alphabetically improves code organization and readability, which is a good practice for maintainability. However, it is not crucial for functionality, hence a moderate score.
    7
    Maintainability
    βœ… Add comments to explain the purpose of each regex pattern ___
    Suggestion Impact:Comments were added to explain the purpose of each regex pattern, improving code maintainability and understanding. code diff: ```diff - // Shopify Shared Secret regex - /shpss_[a-fA-F0-9]{32}/, + return [ + // Shopify Shared Secret regex + /shpss_[a-fA-F0-9]{32}/, - // Shopify Access Token Regex - /shpat_[a-fA-F0-9]{32}/, + // Shopify Access Token Regex + /shpat_[a-fA-F0-9]{32}/, - // Shopify Custom Access Token Regex - /shpca_[a-fA-F0-9]{32}/, + // Shopify Custom Access Token Regex + /shpca_[a-fA-F0-9]{32}/, - // Shopify Private App Access Token - /shppa_[a-fA-F0-9]{32}/ - ] + // Shopify Private App Access Token + /shppa_[a-fA-F0-9]{32}/ ```
    ___ **Consider adding comments to explain what each regex pattern is matching. This will
    make the code more maintainable and easier to understand for other developers.** [packages/secret-scan/src/rules/shopify.ts [5-10]](https://github.com/keyshade-xyz/keyshade/pull/450/files#diff-510d9209169023a10e92bcf009fb86d043fa14a9ddc3c1fcd87a2d0c656faa65R5-R10) ```diff return [ - /shpss_[a-fA-F0-9]{32}/, - /shpat_[a-fA-F0-9]{32}/, - /shpca_[a-fA-F0-9]{32}/, - /shppa_[a-fA-F0-9]{32}/ + /shpss_[a-fA-F0-9]{32}/, // Shopify Shared Secret + /shpat_[a-fA-F0-9]{32}/, // Shopify Access Token + /shpca_[a-fA-F0-9]{32}/, // Shopify Custom App Access Token + /shppa_[a-fA-F0-9]{32}/ // Shopify Private App Access Token ] ``` - [ ] **Apply this suggestion**
    Suggestion importance[1-10]: 6 Why: Adding comments to explain each regex pattern improves code maintainability and understanding for future developers, although it is a minor enhancement.
    6

    πŸ’‘ Need additional feedback ? start a PR chat

    rajdip-b commented 2 months ago

    @kriptonian1

    prabuddha369 commented 2 months ago

    Reverted the changes done in the commit "codebase indentation fix" which affected some unnecessary files like packages/secret-scan/src/rules and web/src/app/(main)/career.

    rajdip-b commented 3 weeks ago

    :tada: This PR is included in version 2.6.0 :tada:

    The release is available on GitHub release

    Your semantic-release bot :package::rocket: