Closed kriptonian1 closed 2 days ago
@Prakhargarg-2010196 would you like to take this issue?
I guess i had already taken both the Ui and backend for this feature the api endpoint for this feature with throttler have been pushed as a PR which @rajdip-b has approved. The Ui i will start working on this week. So yes would be happy to take this
Hi @kriptonian1 , I would like to work on this issue
Hi @kriptonian1 , I would like to work on this issue Sure man 🙌
/attempt
Assigned the issue to @Prakhargarg-2010196!
Hi @kriptonian1 , I would like to work on this issue
Hey man, sadly this issue was already taken by @Prakhargarg-2010196. The assignment was missing!
@kriptonian1 I think so description needs some modifications as #326 mentions a new endpoint for resend-otp (although) internally might be using the same function as send otp.
@rajdip-b what endpoint should we go with ?
@rajdip-b what endpoint should we go with ?
resend-otp/:email as mentioned in #326
@rajdip-b what endpoint should we go with ?
resend-otp/:email as mentioned in #326
Last I had a chat with him, he asked to use send-otp
endpoint
@rajdip-b what endpoint should we go with ?
resend-otp/:email as mentioned in #326
Last I had a chat with him, he asked to use
send-otp
endpoint
@rajdip-b what should be done ?
@rajdip-b what endpoint should we go with ?
resend-otp/:email as mentioned in #326
Last I had a chat with him, he asked to use
send-otp
endpoint
Sending is for one time. Currently we are using it all the time, but ideally we need to move to resend-otp
Should the link be disabled until the throttle limit or we would depend on the errror coming from the throttler to notify the user ?
This is the current view which i had implemented.
Hey @Prakhargarg-2010196, the PR LGTM, I have added a suggestion, once you fix it, it will be good to merge
:tada: This issue has been resolved in version 2.7.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
Description
In the current
auth
flow, we don't have a resent OTP button, meaning if the OTP times out, you don't have a way to get the OTP. You need to implement the resent OTP in the/auth/otp
.Scope of Work
apps/platform/src/app/auth/otp/page.tsx
page.{BASE_URL}/api/auth/send-otp/:email
endpointURLs you need
{BASE_URL}/api/auth/send-otp/:email
link