keyshade-xyz / keyshade

Realtime secret and configuration management tool, with the best in class security and seamless integration support
https://keyshade.xyz
Mozilla Public License 2.0
206 stars 101 forks source link

PLATFORM: Implement resend OTP flow #479

Closed kriptonian1 closed 2 days ago

kriptonian1 commented 1 month ago

Description

In the current auth flow, we don't have a resent OTP button, meaning if the OTP times out, you don't have a way to get the OTP. You need to implement the resent OTP in the /auth/otp.

Scope of Work

kriptonian1 commented 1 month ago

@Prakhargarg-2010196 would you like to take this issue?

Prakhargarg-2010196 commented 1 month ago

I guess i had already taken both the Ui and backend for this feature the api endpoint for this feature with throttler have been pushed as a PR which @rajdip-b has approved. The Ui i will start working on this week. So yes would be happy to take this

Sarveshk76 commented 1 month ago

Hi @kriptonian1 , I would like to work on this issue

kriptonian1 commented 1 month ago

Hi @kriptonian1 , I would like to work on this issue Sure man 🙌

Prakhargarg-2010196 commented 1 month ago

/attempt

github-actions[bot] commented 1 month ago

Assigned the issue to @Prakhargarg-2010196!

rajdip-b commented 4 weeks ago

Hi @kriptonian1 , I would like to work on this issue

Hey man, sadly this issue was already taken by @Prakhargarg-2010196. The assignment was missing!

Prakhargarg-2010196 commented 4 weeks ago

@kriptonian1 I think so description needs some modifications as #326 mentions a new endpoint for resend-otp (although) internally might be using the same function as send otp.

kriptonian1 commented 3 weeks ago

@rajdip-b what endpoint should we go with ?

Prakhargarg-2010196 commented 3 weeks ago

@rajdip-b what endpoint should we go with ?

resend-otp/:email as mentioned in #326

kriptonian1 commented 3 weeks ago

@rajdip-b what endpoint should we go with ?

resend-otp/:email as mentioned in #326

Last I had a chat with him, he asked to use send-otp endpoint

Prakhargarg-2010196 commented 3 weeks ago

@rajdip-b what endpoint should we go with ?

resend-otp/:email as mentioned in #326

Last I had a chat with him, he asked to use send-otp endpoint

@rajdip-b what should be done ?

rajdip-b commented 3 weeks ago

@rajdip-b what endpoint should we go with ?

resend-otp/:email as mentioned in #326

Last I had a chat with him, he asked to use send-otp endpoint

Sending is for one time. Currently we are using it all the time, but ideally we need to move to resend-otp

Prakhargarg-2010196 commented 3 weeks ago

Should the link be disabled until the throttle limit or we would depend on the errror coming from the throttler to notify the user ?

Prakhargarg-2010196 commented 3 weeks ago

This is the current view which i had implemented. resend-otp-2024-10-14_15 26 04

kriptonian1 commented 3 weeks ago

Hey @Prakhargarg-2010196, the PR LGTM, I have added a suggestion, once you fix it, it will be good to merge

rajdip-b commented 13 hours ago

:tada: This issue has been resolved in version 2.7.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: