search

keystone-enclave / keystone-sdk

SDK for Keystone Enclave - ABI/SBI libraries and sample apps
Other
44 stars 22 forks source link

Change Makefile into CMake project #50

Closed khanghua1505 closed 4 years ago

khanghua1505 commented 4 years ago

Hello! This change removes Makefiles and adds CMakeLists into keystone-sdk and lib.

archshift commented 4 years ago

Don't see any issues here, except obviously Travis failing to build.

@dkohlbre CMake is nice in a couple different ways. It allows users to create project files for their IDEs of choice, and use Makefile replacements such as Ninja if they choose. It also makes it incredibly easy to do out-of-tree builds, compared to Makefiles where things get much more challenging (figured that out myself trying to make the test builds happen out-of-tree).

dkohlbre commented 4 years ago

Thanks for fixing the travis! We'll need to update keystone/dev to make this work there as well.