keystone-engine / keypatch

Multi-architecture assembler for IDA Pro. Powered by Keystone Engine.
http://www.keystone-engine.org/keypatch
GNU General Public License v2.0
1.49k stars 355 forks source link

Change dialog for interactive assembler & patcher #3

Closed quangnh89 closed 8 years ago

quangnh89 commented 8 years ago
aquynh commented 8 years ago

this looks good to me, except issue in the inline comment.

thanks.

quangnh89 commented 8 years ago

Thank you for reviewing. I have removed unnecessary keys .

quangnh89 commented 8 years ago

accelerator keys from "Fixup" & "Size" are removed. :)

aquynh commented 8 years ago

i removed the accelerator key for "Encode" field because it is not really useful, and it makes the control unaligned with others. merged, thanks!

aquynh commented 8 years ago

we have some simple features in the TODO list at https://github.com/keystone-engine/keypatch/wiki. if you are bored & out of ideas, feel free to pick up something from the list, thanks!