search

keystone-engine / keypatch

Multi-architecture assembler for IDA Pro. Powered by Keystone Engine.
http://www.keystone-engine.org/keypatch
GNU General Public License v2.0
1.49k stars 355 forks source link

arm patch error #6

Closed a1rsupp1y closed 8 years ago

a1rsupp1y commented 8 years ago

Keypatch: attempt to modify "SUB SP, SP, #8" at 0xB618 to "SUB SP, SP, #0xc" Keypatch: successfully patched 4 byte(s) at 0xB618 from [82 B0 19 A9] to [0C D0 4D E2] this should be from [82 B0 19 A9] to [83 B0 19 A9].

aquynh commented 8 years ago

do you mean the log info is wrong, or also the patching is wrong?

a1rsupp1y commented 8 years ago

also the patching is wrong too

redragonvn commented 8 years ago

I've fixed this issue. Please checkout the latest code.

redragonvn commented 8 years ago

We might need to add to UI a field to show wherether instruction is on ARM or THUMB encoding mode

a1rsupp1y commented 8 years ago

good job

aquynh commented 8 years ago

close, thanks.