keystone-engine / keystone

Keystone assembler framework: Core (Arm, Arm64, Hexagon, Mips, PowerPC, Sparc, SystemZ & X86) + bindings
http://www.keystone-engine.org
GNU General Public License v2.0
2.3k stars 458 forks source link

Python package silently skips build on macOS if cmake is not installed #544

Open 4ndv opened 2 years ago

4ndv commented 2 years ago

When installing keystone-engine via pip, binaries are not built when cmake is not installed, but build step is reported as "done":

▲ ~ pip3 install keystone-engine
Collecting keystone-engine
  Using cached keystone-engine-0.9.2.tar.gz (2.8 MB)
  Preparing metadata (setup.py) ... done
Building wheels for collected packages: keystone-engine
  Building wheel for keystone-engine (setup.py) ... done
  Created wheel for keystone-engine: filename=keystone_engine-0.9.2-py2.py3-none-macosx_13_arm64.whl size=9880 sha256=a29ebdd933b7a0d1d86a68750e1870b10ce21d13c0fbf82590507c0603c93db9
  Stored in directory: /Users/lynx/Library/Caches/pip/wheels/66/90/bc/095988edfc149f163f938738c2c12d14855228919a7938b954
Successfully built keystone-engine
Installing collected packages: keystone-engine
Successfully installed keystone-engine-0.9.2
▲ ~ cd /opt/homebrew/lib/python3.10/site-packages/keystone/
▲ keystone [stable] ll
total 104
-rw-r--r--   1 lynx  admin   311B 13 ноя 21:45 __init__.py
drwxr-xr-x  14 lynx  admin   448B 13 ноя 21:45 __pycache__
-rw-r--r--   1 lynx  admin   185B 13 ноя 21:45 arm64_const.py
-rw-r--r--   1 lynx  admin   177B 13 ноя 21:45 arm_const.py
-rw-r--r--   1 lynx  admin   177B 13 ноя 21:45 evm_const.py
-rw-r--r--   1 lynx  admin   193B 13 ноя 21:45 hexagon_const.py
-rw-r--r--   1 lynx  admin   7,6K 13 ноя 21:45 keystone.py
-rw-r--r--   1 lynx  admin   2,2K 13 ноя 21:45 keystone_const.py
-rw-r--r--   1 lynx  admin   181B 13 ноя 21:45 mips_const.py
-rw-r--r--   1 lynx  admin   177B 13 ноя 21:45 ppc_const.py
-rw-r--r--   1 lynx  admin   185B 13 ноя 21:45 sparc_const.py
-rw-r--r--   1 lynx  admin   193B 13 ноя 21:45 systemz_const.py
-rw-r--r--   1 lynx  admin   177B 13 ноя 21:45 x86_const.py