search

keystonejs-contrib / k6-contrib

Keyston-6 contrib
MIT License
35 stars 18 forks source link

Fix peer dependency issues #29

Closed skeary closed 2 years ago

skeary commented 2 years ago

This PR addresses the problems outlined in https://github.com/keystonejs-contrib/k6-contrib/issues/22 and https://github.com/keystonejs-contrib/k6-contrib/issues/28 by updating the peerDependencies field in the affected packages.

These changes are a subset of the changes I proposed in https://github.com/keystonejs-contrib/k6-contrib/pull/27. As requested over Slack, I've taken out the changes to add linting and they can potentially be done in a subsequent PR.

The key change is to update the entry for @keystone-6/core from @keystone-6/core": ">=^1.0.0 to @keystone-6/core": ">=^1.0.0. In addition, there were a number of packages that used graphql-upload but did not have an entry for it in their production or peer dependency arrays. I've added it as a peer dependency. Where the packages have a (dev) dependency on graphql, I've bumped the dependency from 15.7.2 to 15.8.0 as this is was KS core uses and it seems like a good idea to use the same - note this won't have an effect on any consumers of the packages.

For the examples package.json files, I've updated their dependencies to add in some missing dependencies. I've also updated the version used of dotenv to be a consistent ^16.0.0 everywhere to address a yarn install warning.

Could you take a look, please? I'm happy to make further changes.

gautamsi commented 2 years ago

I have reverted some package versions to match their version in keystone repo at that time, I am going to have a major release to match version with keystone with updated dependencies.