search

keystonejs / keystone-6-heroku-example

A simple example project of showing how you might deploy Keystone 6 to Heroku
15 stars 15 forks source link

Change semver range syntax for node version to be 'safe' #6

Closed ettmetal closed 3 years ago

ettmetal commented 3 years ago

This should solve #5, allowing deployment via the Heroku button.

A carent range will prevent it working on newer major versions of node than 14, but will allow it to work on any minor / patch version greater than or equal to 14.13, as declared previously.

It seems some part of the process on Heroku is declaring it 'unsafe' to spcify that the app will continue to work on possibly unknown future versions. In testing, this results in the deployment of keystoneJS into Heroku sucessfully.

bladey commented 3 years ago

Thanks @ettmetal, you beat me to it. Ideally it would work with Node 17, but also needs a safer range, will look into this shortly.

bladey commented 3 years ago

Hi @ettmetal, thanks again, this has now been tweaked to the following pattern, Keystone has also been updated - https://github.com/keystonejs/keystone-6-heroku-example/commit/64db1553254bfc9377217fa6d246d47515ca01f8