keystonejs / keystone-classic

Node.js CMS and web app framework
http://v4.keystonejs.com
MIT License
14.64k stars 2.21k forks source link

Field Note Not Displaying #4327

Open cdenm opened 7 years ago

cdenm commented 7 years ago

Expected behavior

Adding the "note" option to a field in a model results in that note being displayed near the field in the Admin UI.

Actual/Current behavior

Adding the "note" option to a field in a model does not do anything visible.

Steps to reproduce the actual/current behavior

Add a "note" to a field in a model and then go to the Admin UI and you will see that the note has not appeared.

Environment

Keystone is being run on the Powershell on a Windows 10 machine. Not sure what else you'd need to know.

Software Version
Keystone 4.0.0-beta.5
Node v7.4.0
icyretribution commented 7 years ago

Could not replicate within my own models. All notes appeared under the fields at which they were added to. Do you have any further references as far as what field type? is it a new experimental type? is it a standard keystone registered type?

esalling23 commented 7 years ago

@icyretribution I have noticed across my KeystoneJSv4 projects that fields using the CloudinaryImage field type do not display notes. These same notes will appear if used on other field types. Is this a known bug?

Noviny commented 7 years ago

@esalling23 This is not a known bug. Going to set resolving this as resolving notes on cloudinaryImage fields.

tortilaman commented 7 years ago

I'm having this same error with fields that are of number type as well as string type. I'm on OSx.

yazevedopure commented 5 years ago

You can check the renderUi method in fields/types/cloudinaryimage/CloudinaryImageField.js and fields/types/cloudinaryimages/CloudinaryImagesField.js

the line {!!note && <FormNote note={note} />} should be {!!note && <FormNote html={note} />}

the same happens in fields/types/datetime/DatetimeField.js and fields/types/location/LocationField.js