keystonejs / keystone-classic

Node.js CMS and web app framework
http://v4.keystonejs.com
MIT License
14.65k stars 2.21k forks source link

Money/ Number fields remain unformatted on render #4911

Closed realThinhIT closed 5 years ago

realThinhIT commented 5 years ago

I'm currently experiencing bugs about field types: Money or Number. Numeral wouldn't format money or number fields.

Expected behavior

It should have been formatted on page load. It works fine on the KeystoneJS demo.

Actual/Current behavior

Imgur

Imgur

Steps to reproduce the actual/current behavior

  1. Using type: Types.Money or type: Types.Number on a Number field.

Environment

Software Version
Keystone ^4.0.0
Node.js v10.1.0
Browser Chrome 73.0/ Safari 12.0
realThinhIT commented 5 years ago

Issue found, please check my pull request: https://github.com/keystonejs/keystone/pull/4912

JedWatson commented 5 years ago

Merged the pull request, thanks!