Fix NumberColumn for money formatting be independent from path name - Githubissues

keystonejs / keystone-classic

Node.js CMS and web app framework

http://v4.keystonejs.com

MIT License

14.65k stars 2.21k forks source link

Fix NumberColumn for money formatting be independent from path name #4912

Closed realThinhIT closed 5 years ago

realThinhIT commented 5 years ago

Description of changes

Money formatting NumberColumn requires the path (field name) to be exactly money to be rendered correctly.

This change is to make the formatting/ rendering process name-independent and renders correctly when only money field type is met.

Related issues (if any)

Testing

[x] List browser version(s) any admin UI changes were tested in: Google Chrome Version 73.0.3683.86 (Official Build) (64-bit).
[x] Please confirm you've added (or verified) test coverage for this change.
[x] Please confirm npm run test-all ran successfully.

JedWatson commented 5 years ago

Good catch @realThinhIT, thanks!