add support for language cookie options - Githubissues

keystonejs / keystone-classic

Node.js CMS and web app framework

http://v4.keystonejs.com

MIT License

14.64k stars 2.2k forks source link

add support for language cookie options #4921

Closed Hsn723 closed 5 years ago

Hsn723 commented 5 years ago

Description of changes

https://github.com/keystonejs/keystone/blob/master/lib/middleware/language.js#L8 The language middleware accepts a language cookie options configuration, but that value is not being used when creating the cookie: https://github.com/keystonejs/keystone/blob/master/lib/middleware/language.js#L14-L17

This PR fixes this by consuming the given option.

Related issues (if any)

Testing

[x] List browser version(s) any admin UI changes were tested in: Chrome 74
[x] Please confirm you've added (or verified) test coverage for this change.
[x] Please confirm npm run test-all ran successfully.

JedWatson commented 5 years ago

Thanks @Hsn723!