keystonejs / keystone-classic

Node.js CMS and web app framework
http://v4.keystonejs.com
MIT License
14.62k stars 2.21k forks source link

fix value for noEdit InputForm in UrlField #4937

Closed laurenskling closed 5 years ago

laurenskling commented 5 years ago

PR https://github.com/keystonejs/keystone/pull/4856/ resulted in a bug when UrlField was set to noedit

this fixes it again.

laurenskling commented 5 years ago

value needs to be passed down as children.

laurenskling commented 5 years ago

The original PR doesn't add any documentation by the way, so the thumb flag is not documented right now for UrlField

Tathanen commented 5 years ago

+1 for this PR, I just noticed this issue when pulling in the latest Keystone changes in my fork. Let's get a merge!

JedWatson commented 5 years ago

👍 Thanks @laurenskling