keystonejs / keystone-email

⚠️ Archived - Legacy email helper for KeystoneJS Apps
MIT License
29 stars 40 forks source link

Nodemailer transport doesn't found #14

Open ivanclaud opened 7 years ago

ivanclaud commented 7 years ago

Hi,

I'm trying to send email using nodemailer but nodemailer package doesn't found if i install using npm install keystone-email

So done a workaround, installed from github npm install https://github.com/keystonejs/keystone-email.git

LorbusChris commented 7 years ago

You need to manually add nodemailer to your project as well. If it is not yet listed in your package.json, run:

npm install --save nodemailer

ivanclaud commented 7 years ago

Thanks @LorbusChris

Yes I had installed nodemailer initially .

But the issue is , If I set transport as nodemailer then it's explicitly looking for lib/transports/nodemailer/index.js which is not found

LorbusChris commented 7 years ago

Oh yea, you're actually on to something. There hasn't been published a new version to npm since addition of the nodemailer transport. For the time being, in your dependencies in package.json you can specify

"keystone-email": "https://github.com/keystonejs/keystone-email.git",

to pull master from this repo directly on npm install.

@JedWatson do you mind publishing a new version to npm? I'd be excited to see how the nodemailer transport performs out in the open =)

neagle commented 7 years ago

I just ran into this issue as well. Thanks to @ivanclaud for pointing it out. Happy to switch to listing the Github repo for now, but it's be great to get the npm version updated. 😄

ivanclaud commented 7 years ago

Just publishing package to npm may not work . Because I ran into this (https://github.com/keystonejs/keystone-email/issues/15) as well

Brmm commented 7 years ago

Is there a reason this is not published on npm yet? Linking to a github master branch is not wise in production.