Switch to aws-sdk S3 client

keystonejs / keystone-storage-adapter-s3

⚠️ Archived - Legacy S3 Storage Adapter for KeystoneJS

MIT License

17 stars 56 forks source link

Switch to aws-sdk S3 client #15

Closed sktt closed 6 years ago

sktt commented 7 years ago

Hi there!

The knox s3 client seems to not be maintained very well so here's an example how we can do the same same thing using the official aws-sdk.

Let me know if you're interested in this and I'd clean it up, update readme, tests and whatnot

Cheers

r3wt commented 7 years ago

@JedWatson status on this?

michaek commented 6 years ago

It seems this should probably be merged, even if it's not a perfect replacement for the knox implementation. Support for IAM roles seems pretty essential nowadays.

bflopez commented 6 years ago

Is there another thread to follow for replacing Knox with aws-sdk? Researching KeystoneJS right now for a project and this is one of the things holding me back from starting it. Can't get S3 to work.

mikehazell commented 6 years ago

closing this in favour of #35