search

keystonejs / keystone-storage-adapter-s3

⚠️ Archived - Legacy S3 Storage Adapter for KeystoneJS
MIT License
17 stars 55 forks source link

Complete Revamp of Adapter #30

Closed aaronfranco closed 6 years ago

aaronfranco commented 6 years ago

This version uses the AWS SDK directly and updates the adapter S3 parameter object to take advantage of all the S3 SDK parameters available to the API. Also, it adds headers to requests correctly and uses file.mimetype and file.size to correctly add Content-Type and Content-Length headers to the S3 upload Object. Finally, instead of using "s3.upload" this adapter uses "s3.putObject" which follows the SDK best practices and preserves any versioning that might be enabled on S3

mikehazell commented 6 years ago

Thanks @aaronfranco and sorry for the lack of feedback on this issue. I'm closing this PR in favour of #35 which stays close to the original API.