search

keystonejs / keystone

The superpowered headless CMS for Node.js — built with GraphQL and React
https://keystonejs.com
MIT License
9.15k stars 1.15k forks source link

Add Static Type Checking with Hegel #2989

Closed jesstelford closed 3 years ago

jesstelford commented 4 years ago

Feature request

Is your feature request related to a problem? Please describe.

Adding types to our codebase is a non-starter.

The main problem types are solving is the static analysis. Could we have that without any of the downsides of TypeScript, like adding types?

Yes.

Describe the solution you'd like

Add Hegel's static type checker to our test / CI process (but no types).

Describe alternatives you've considered

See #1373.

Also, we used to have Flow, but striped it out because it was noisy and annoying to work with.

Additional context

MadeByMike commented 4 years ago

If it doesn't offer the same level of auto-completion in VSCode as TypeScript it's not valuable for me. Personally I care less about the purity of type safety, I just want to know what the item value contains in the async access control function I'm writing without stepping through 5 layers of Keystone's core code.

stale[bot] commented 3 years ago

It looks like there hasn't been any activity here in over 6 months. Sorry about that! We've flagged this issue for special attention. It wil be manually reviewed by maintainers, not automatically closed. If you have any additional information please leave us a comment. It really helps! Thank you for you contribution. :)