search

keystonejs / keystone

The superpowered headless CMS for Node.js — built with GraphQL and React
https://keystonejs.com
MIT License
9.18k stars 1.15k forks source link

Deprecate ambiguous `extendHttpServer` GraphQLSchema argument #9028

Closed dcousens closed 7 months ago

dcousens commented 7 months ago

This pull request deprecates extendHttpServer's argument for graphqlSchema, with preference for new code to use the context.graphql.schema if you need that.

The graphqlSchema argument is ambiguous, as you don't know without introspection if you are being passed the sudo context schema or the public context schema.

codesandbox-ci[bot] commented 7 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ec9685f9588029b66a1b89e6c3889009b9ae9ead:

Sandbox Source
@keystone-6/sandbox Configuration