search

keystonejs / keystone

The most powerful headless CMS for Node.js — built with GraphQL and React
https://keystonejs.com
MIT License
8.98k stars 1.13k forks source link

chore(deps): bump next major version to 14.x #9170

Closed direisc closed 3 weeks ago

direisc commented 3 weeks ago

Next has an active vulnerability https://security.snyk.io/package/npm/next/13.5.4 Bump the next version to higher version.

I caught some issues running tests locally. If someone can help, I can try to solve the possible issues.

codesandbox-ci[bot] commented 3 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0873c2cb7eaba2b2b2c11372e5ab4ef07d7778ee:

Sandbox Source
@keystone-6/sandbox Configuration
direisc commented 3 weeks ago

@dcousens the Experimental ESM Externals flags are set to loose to solve an issue when building admin UI. This is related to an issue when building a react-day-picker peer dependency with no proper type (ESM/CommonJS).

NextJS shows some ways to solve it at https://nextjs.org/docs/messages/import-esm-externals The workaround to don't need to fix the type of project or work at react-day-picker is adding experimental: { esmExternals: 'loose' }, to let the Next build try to solve the import.

direisc commented 3 weeks ago

To clarify the issue around react-day-picker:

Screenshot 2024-06-12 at 12 34 55
dcousens commented 3 weeks ago

Thanks @direisc, this is really appreciated :green_heart: