Add a component to render.

keystonejs / universal-keystone-boilerplate

⚠️ Archived - Legacy Keystone.JS boilerplate for Universal JavaScript projects using React.

MIT License

34 stars 10 forks source link

Closed ericelliott closed 8 years ago

ericelliott commented 8 years ago

Merge strict-lint first.

JedWatson commented 8 years ago

Looks good to me.

Curious though - what are your thoughts on https://github.com/airbnb/enzyme?

From my (admittedly cursory) review I like it, seems easy to code + follow.

JedWatson commented 8 years ago

(merging anyway because timezones, and if you don't like enzyme I'm 100% happy to push forward with this)

ericelliott commented 8 years ago

I love the idea of Enzyme. In practice, it has a lot of quirks that need smoothing over. In particular:

Events don't bubble -- event testing is the whole reason Enzyme is more promising than Cheerio for component tests.
Even basic DOM queries that work great in Cheerio currently fail in Enzyme, which can be time consuming and frustrating to debug. I'll happily keep exploring Enzyme and filing bug reports in my personal projects, but I don't want to waste company time on it.