search

kezhenxu94 / mini-github

GitHub WeChat Mini Program
Apache License 2.0
1.2k stars 88 forks source link

What's the feed content with user logged out? #17

Closed johnnychen94 closed 5 years ago

johnnychen94 commented 5 years ago

I thought the feed page should contain nothing or "login to get news" (BTW I prefer the name News to Feed), but it actually contains some relatively meaningless content.

Close this issue if it's your deliberately designed behavior.

kezhenxu94 commented 5 years ago

The feed content are GitHub global news actually, news look good to me

kezhenxu94 commented 5 years ago

Changed Feeds to News in the latest version.

but it actually contains some relatively meaningless content.

It's GitHub global news, I think it's better to show some global news than an empty page