What access permissions are necessary for login with token?

kezhenxu94 / mini-github

GitHub WeChat Mini Program

Apache License 2.0

1.2k stars 88 forks source link

What access permissions are necessary for login with token? #6

Closed johnnychen94 closed 5 years ago

johnnychen94 commented 5 years ago

I'd like to try this mini program but I'm not sure what access permissions should I give when creating a new token https://github.com/settings/tokens/new. All checked seems to be overkill.

My guess is:

Repo: all
user: all
notification: all

But looks like it's not enough, at least the issue list is not displayed normally; only several outdated issues are listed. -- not sure if this is a bug or caused by wrong token settings.

kezhenxu94 commented 5 years ago

I'd like to try this mini program but I'm not sure what access permissions should I give when creating a new token https://github.com/settings/tokens/new. All checked seems to be overkill.

My guess is:

Repo: all

user: all

notification: all

But looks like it's not enough, at least the issue list is not displayed normally; only several outdated issues are listed. -- not sure if this is a bug or caused by wrong token settings.

Thanks for your interest in this project, I think your guess is right and the listed scopes are enough, I believe it's a bug here, thanks for reporting this, I'll try to fix it in the next version :)

kezhenxu94 commented 5 years ago

Hi @johnnychen94 I've just fixed this bug and submitted to WeChat for review, it should be available tomorrow :) I've also added a feature that shows contributors in repository detail page, please give it a try tomorrow and feel free to feed back here, thanks :)

kezhenxu94 commented 5 years ago

Hi @johnnychen94 , the new version that fixes this bug is released just now, please give it a try, if it doesn't work, please make sure exit the mini program completely and restart, thanks again for reporting this. I'm closing this for now

johnnychen94 commented 5 years ago

Looks like it still doesn't work.

I've deleted this mini-program and rescanned the QR code to open it. -- I guess this means "exit the mini program completely and restart" I've also regenerated an all-permitted token to login. -- this issue is not related to limited token permission.

Perhaps it's just because of a server-side update delay, I'll check it later today. @kezhenxu94

I can provide more information if you need.

kezhenxu94 commented 5 years ago

That's weird, if it still doesn't work, feel free to reopen this issue