search

kezhenxu94 / mini-github

GitHub WeChat Mini Program
Apache License 2.0
1.2k stars 88 forks source link

Enhancement: tag or change items in "Closed PRs" list #7

Closed johnnychen94 closed 4 years ago

johnnychen94 commented 5 years ago

The current closed PRs list doesn't offer much information because Closed PR is a superset of Merged PR. Take the screenshot as an example: which PRs are closed and which PRs are merged?

A simple and effective solution to this is to list only non-merged closed PRs in the "Closed PRs" list.

Another solution is to tag each item with merged or closed

image

kezhenxu94 commented 5 years ago

nother solution is to tag each item with merged or closed

I prefer this one, what do you think :) because GitHub webpage shows merged prs in the closed tab too

johnnychen94 commented 5 years ago

This's the first workaround I came up with, but since you already provide a Merged list, there's no need to do so.