search

kezhenxu94 / vim-mysql-plugin

VIM MySQL Plugin
Apache License 2.0
21 stars 6 forks source link

Deletes last rows of output - sometimes #14

Open artfulrobot opened 1 year ago

artfulrobot commented 1 year ago

I found myself getting a lot of truncated output.

Commenting out this line https://github.com/kezhenxu94/vim-mysql-plugin/blob/2f2120059b1b367390eac6a47b29b24551d434e4/plugin/vim-mysql-plugin.vim#L29

fixes it.

kezhenxu94 commented 1 year ago

How can I reproduce?

artfulrobot commented 1 year ago

yeah, sorry, I've not figured that out either.

<leader>ds seems most sensitive to it. Here's screenshots of one table with the line present, and commented.

Current

image

Desired

image

Why

Ah! I've got it - I think. I think it's because the normal kdG line is assuming there's timing information at the bottom, but this is not output for describe table.

kezhenxu94 commented 1 year ago

@artfulrobot this looks weird tome, I can always see the timing information for describe table, can you do the raw query describe xxx in your mysql cli and see whether the timing information exists?

kezhenxu94 commented 1 year ago

And if you remove normal kdG, what happened to the other commands? I think we can remove the normal kdG if it doesn't affect much to other commands.

artfulrobot commented 1 year ago

The command in question is there just to delete the timing info from the output. So if it's not run, then the timing info is appended to the output, as it was before a recent PR that sought to move it to an echo/message command.

kezhenxu94 commented 1 year ago

I can confirm it occurs, I'm going to revert the related commit.

kezhenxu94 commented 1 year ago

@artfulrobot please update and retry