kfarr / aframe-city-builder

🏗️ A-Frame project demonstrating touch controls for building a VR city scene
https://aframe.city
MIT License
87 stars 37 forks source link

feature request - add second controller #5

Closed micahstubbs closed 7 years ago

micahstubbs commented 7 years ago

can reproduce the issue in both 54.0a1 (2017-01-29) (64-bit) Firefox Nightly and Aug 29 Chromium screenshot 1485732926

screenshot 1485732881

micahstubbs commented 7 years ago

ok, got aframe-city-builder latest master running locally.

the controllerEl variable is declared, so no more error about that in the console.

micahstubbs commented 7 years ago

starting to suspect that the experience might be designed for just one controller :thinking:

micahstubbs commented 7 years ago

ok, saw the note in README.md about adding a second controller in the future. count this as a feature request then 😉

kfarr commented 7 years ago

I thought I had fixed all those webpack use strict errors, but you found a new one! I just fixed the one you found, but I also updated index.html to ignore the dist build and just reference each js file itself, effectively removing "use strict".

As far as the second controller is concerned, I could add it just as a second object browser and placer, but I'm thinking of adding a "menu" with things like load, save, teleport, etc which might live on that other hand.

kfarr commented 7 years ago

Also it seems like it worked in 54.0a1 (2017-01-29) Firefox Nightly but none of the chromiums? It does work for me in Dec 23

kfarr commented 7 years ago

Finally, the dev work required to add a second controller is to modify the "aframe-select-bar" component to append a unique name to the ID of elements it generates such that more than one instance of the component can be active on one scene. I'm planning to start that tonight as I need to writeup the component anyway.

micahstubbs commented 7 years ago

could add it just as a second object browser and placer

as an exercise to learn about the project, I went down this path on a branch this afternoon. I got both controllers & object menus to render, but the trackpad events to scroll the menu weren't working.

append a unique name to the ID of elements it generates

good to know! hadn't figured this out yet. likely just the thing I was missing 😄

micahstubbs commented 7 years ago

🎉