kfatehi / ydm

yet another Docker management tool
ISC License
9 stars 3 forks source link

looks like drops have hardcoded config #12

Closed jaredly closed 10 years ago

jaredly commented 10 years ago

See this line. Or am I missing something?

Seems like it would be nice to have two options

dew strider install --config=myfile.json

and interactive mode

$ dew gitlab install
Gitlab requires some custom configuration. 
You can either provide this with the --config=myfile.json 
argument, or answer the following questions interactively:

1) smtp server (e.g. mydomain.com): _
kfatehi commented 10 years ago

@jaredly you're right -- those are remnants from my testing. i like your idea of passing in JSON or falling back to an interactive mode... dew definitely needs more eyes, i'm glad you're looking at it. once it's done it will be the official installer for docker-gitlab (see https://github.com/sameersbn/docker-gitlab/issues/119#issuecomment-51384897) so i would really like to get it right :+1:

kfatehi commented 10 years ago

we'll check if --config is set, otherwise we'll present the user with a wizard via https://github.com/isaacs/promzard

kfatehi commented 10 years ago

I decided not to use Promzard, instead an example file is shown in the error message.

keyvan@docker:~ ❯❯❯ sudo ydm gitlab install --namespace knban                                       ⏎
Requirement not satisfied: --env
Requirement reason: highly customizable through environment variables, pass in a JSON file. Example: {
    "SMTP_DOMAIN": "knban.com",
    "SMTP_HOST": "localhost",
    "SMTP_PORT": 25,
    "GITLAB_HTTPS": true,
    "GITLAB_HTTPS_ONLY": false,
    "GITLAB_HOST": "gitlab.knban.com",
    "GITLAB_EMAIL": "gitlab@knban.com"
}
For more information visit https://github.com/sameersbn/docker-gitlab
cannot continue