kfdesign / WareHouse

0 stars 0 forks source link

Summary #1

Open tbergen1 opened 5 years ago

tbergen1 commented 5 years ago

Rubric Score

Criteria 1: All Pages are Included

Criteria 2: CSS

Criteria 3: Use of CSS Selectors and Syntax

Criteria 4: CSS Grid

Criteria 5: Branding

Criteria 6: Typography

Criteria 7: Page Linking

Criteria 8: Accessibility

Criteria 9: Responsive Design

Overall Score: 35/36

Overall, you did a great job with this project. Your formatting was great, making all of code easy to read. You demonstrated good knowledge of both HTML and CSS - using semantic elements appropriately in the HTML and choosing appropriate selectors. Your design and branding was minimal and consistent throughout. You made good choices when it came to typography as well. Some areas of improvement would be to add accessibility features in the form of aria roles to you pages to help screen readers. Other than that, great work!

kfdesign commented 5 years ago

Thank you very much for such a thorough review of my project. I agree with you about the lack of aria roles and realize that this is something I need to work on more. Thank you again for your time.