kfdesign / prj-rev-bwfs-tea-cozy

0 stars 0 forks source link

Subtle: Sizing dimensions #4

Open blerude opened 6 years ago

blerude commented 6 years ago

https://github.com/kfdesign/prj-rev-bwfs-tea-cozy/blob/master/TeaCozy/resources/css/style.css#L36-L37

Here, you set the height to an unchangeable size while the width is a %. It's generally better to stick to % dimensions so that the app is more responsive to different sized screens (i.e. on your tablet, on your phone, etc.). Not necessary, but good to think about!

kfdesign commented 6 years ago

Thank you. I will keep this in mind going forward. I am just starting the next section — about responsive design and proportions. I can see how your suggestion makes a lot of sense. In one of our lessons, there was a suggestion to make the navigation menu width 100%. In this lesson they had specified the height as 69px.