search

kfei / slack-cleaner

:speech_balloon: Bulk delete messages and files on Slack
MIT License
1.24k stars 144 forks source link

Disable logs #9

Closed renshuki closed 8 years ago

renshuki commented 8 years ago

Hi, You did a great job with this library. Thank you. A nice feature would be to use argument --no-log to skip logging ;)

kfei commented 8 years ago

Sounds good. Thanks for the suggestion. :smile: I'll add this flag when I have some free time. As always, pull requests are welcome!

renshuki commented 8 years ago

I thought it was better to use --log to create a log file than --no-log to skip it. If you prefer to implement --no-log instead I can create another pull request. Let me know ;)

kfei commented 8 years ago

@renshuki Awesome! Many thanks for your fast PR. And the --log design looks pretty good to me. :smile:

renshuki commented 8 years ago

@kfei Thank you for the merge! =) I close the issue. I'll let you know if I have other improvement ideas.

kfei commented 8 years ago

Sweet!