Open jose920405 opened 6 years ago
Yeah, all this stuff is fixed there, I'm using own fork which is already merged to rn-fetch-blob, but can't change react-native-fetch-blob to rn-fetch-blob cause cached-image using it so I must still use my own fork:
"react-native-fetch-blob": "github:flatfox-ag/react-native-fetch-blob#a46bf8180d76131eafe84ab44e0436322073820c",
if interested.
This way you will have native code with fixes, even cached-image dependency is for different version (and repo).
But better will be to use ready PRs repo commit:
"react-native-cached-image": "github:fungilation/react-native-cached-image#c3da553d3e5b05a0b2b2004268ce1f56fec762db",
which I will test now and probably use.
There is also yarn way:
"resolutions": {
"react-native-cached-image/react-native-fetch-blob": "github:joltup/rn-fetch-blob#2a81f32def50e7ddf98176f19d62285b77853b54"
},
but above PR also uses Promises to reject instead throwing exception in fsUtils (react-native-cached-image).
Note that to use my fork (fungilation/), change native installation in your own app to pod 'rn-fetch-blob', :path => '../node_modules/rn-fetch-blob'
. For existing install, that involves react-native unlink
and yarn remove, and add / link again.
I'm using in my app WonderSwipe without issue.
I have presented multiple crashes in my application for many users. Currently the app has a large number of users, which makes these sporadic crashes more visible.
Following up with the help of AppSee, I realized that a large percentage of crashes are on the screens where images are loaded with this library. This affects less than 2% of the users, but they are enough to be taken into account.
I was also able to replicate them in the simulator in release mode and I was able to determine what is caused by
react-native-fetch-blob
.Following this problem, I realized that the only place where
react-native-fetch-blob
is as a dependency is in this library, also reviewing this module I realized that it seems that they are not maintaining it. It seems that now must be usedrn-fetch-blob
https://github.com/wkh237/react-native-fetch-blob#rnfb-maintainer-gone-missing-help-wanted
I would greatly appreciate that you follow this thread, since this bookstore has been very helpful to me.