search

kfiroo / react-native-cached-image

CachedImage component for react-native
MIT License
940 stars 468 forks source link

Unexpected error on render <CachedImage /> #129

Open joaom182 opened 6 years ago

joaom182 commented 6 years ago 
Error in callNativeModules();
Malformed calls from JS: fields sizes are different.

screen shot 2018-07-19 at 03 14 04

joaom182 commented 6 years ago

This issue is caused by the latest version is using react-native-fetch-blob instead of using rn-fetch-blob.

@fungilation makes a fork that's correct the dependency, so i sugest to use this fork.

JensDebergh commented 5 years ago

If react-native-fetch-blob changed their name to rn-fetch-blob should we just merge @fungilation's fork and merge it into master?

The library react-native-cached-image is completely broken right now on latest versions of react-native.

react-native-fetch-blob is officially discontinued in favor of rn-fetch-blob

ARMATAV commented 5 years ago

@JensDebergh yes please - this is causing all sorts of issues, including breaking release builds for Android

cyqui commented 5 years ago

The project according to the contributors charts and the last commits seem rather dead,so unfortunately i have the feeling the PR is not going to be merged any soon.

https://github.com/kfiroo/react-native-cached-image/graphs/contributors

@kfiroo Would be great if the README could mention to use fungilation/react-native-cached-image or any more popular fork you'll recommend. All the failed installs are consuming a lot of power energy and we are killing polar bears by giving outdated code without warnings.

venux92 commented 5 years ago

@joaom182 Great, been trying to debug it all day you just made my day

andho commented 5 years ago

netinfo package is needed now. https://github.com/fungilation/react-native-cached-image/commit/363dea9b4e37a605faa15c5ea4dd502f98736831

fungilation commented 5 years ago

I know. See my last commit on my fork, tested to work with up to RN 0.59.5: https://github.com/fungilation/react-native-cached-image/commits/master

fungilation commented 5 years ago

On topic of maintenance and forking: https://github.com/kfiroo/react-native-cached-image/issues/160