search

kfiroo / react-native-cached-image

CachedImage component for react-native
MIT License
938 stars 470 forks source link

Update TypeScript types to reflect examples. #169

Open jckw opened 4 years ago

jckw commented 4 years ago

The current declaration file specifies doesn't specify any props as optional, although most actually are. This makes the package difficult to use in TypeScript projects without lots of @ts-ignores.

The examples in the README also make it clear that most props aren't required. If I can get some guidance on what is optional, I'll happily make the changes and put together a PR.

Alternatively, the typings could be moved to the DefinitelyTyped repo.

AmitDigga commented 4 years ago

Its really hard to work with incorrectly typed package.