search

kfiroo / react-native-cached-image

CachedImage component for react-native
MIT License
938 stars 470 forks source link

Listen NetInfo connectionChange event (change deprecated) #76

Closed ghost closed 6 years ago

ghost commented 6 years ago

Fixes #75

kfiroo commented 6 years ago

@kytwb Great, thanks! Just a quick question, would that cause a problem for users with lower versions of RN? (I think it's polite to support at least 1-2 previous versions)

ghost commented 6 years ago

@kfiroo I'll check and make it backward compatible if possible. If not possible, what should I do? Follow semver and major/minor the version?

kfiroo commented 6 years ago

@kytwb Thanks! If you can't make it backward compatible we should merge it after the 1.4 version, which already forces users to upgrade

chrusart commented 6 years ago

Will this work? https://github.com/facebook/react-native/issues/12503 just check if RN >= 0.48.0 then use connectionChange event name its just a lot of warnings in console, but probably should be made in normal a way, changed in 1.4.