search

kfish / libfishsound

A simple programming interface for decoding and encoding audio data using Xiph.org codecs (FLAC, Speex and Vorbis)
http://www.annodex.net/software/libfishsound/
BSD 3-Clause "New" or "Revised" License
14 stars 3 forks source link

Drop Requires: line from fishsound.pc.in #1

Closed michel-slm closed 14 years ago

michel-slm commented 14 years ago

This line is only needed if packages that build against libfishsound needs access to the Cflags of the required packages. In this case, the listed packages (vorbis, speex, flac) are precisely the packages that libfishsound provide a wrapper API for, so apps compiling against libfishsound really should not need their headers directly.

This was not a problem in 0.9.1, but in 1.0.0 the FLAC headers are exported, and this include a really regrettably misnamed assert.h, which shadows the system assert.h and causes compilation of sonic-visualiser to fail.

I've tried removing the Requires: line and can report that it results in a functioning sonic-visualiser build.

diff below: --- fishsound.pc.in.noreq 2009-03-28 04:40:03.000000000 +0100 +++ fishsound.pc.in 2010-07-03 23:01:31.582347750 +0200 @@ -5,7 +5,6 @@

 Name: fishsound
 Description: Encode and decode Vorbis, Speex, FLAC audio
-Requires: @fishsound_pkgdeps@
 Version: @VERSION@
 Libs: -L${libdir} -lfishsound
 Libs.private: @VORBIS_LIBS@ @SPEEX_LIBS@ @FLAC_LIBS@
kfish commented 14 years ago

Thanks, applied!