search

kfix / MacPin

a webapp container & site specific browser made from WebKit.swift and JavaScriptCore
GNU General Public License v3.0
331 stars 27 forks source link

rects(forCharacterRange:) & Catalina #36

Closed justingeeslin closed 2 years ago

justingeeslin commented 3 years ago

Running make install on macOS Catalina (10.15.6) returns the following errors. 

modules/MacPin/WebView.swift:1307:27: error: 'rects(forCharacterRange:)' is only available in macOS 10.15 or newer
                guard let frects = self.rects(forCharacterRange: range),
``` $ make install [eXcode.mk] modules/ => MacPin Prompt UTIKit macos sdk: => /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk swiftlibs: => /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/macosx => swiftc: => Apple Swift version 5.2.4 (swiftlang-1103.0.32.9 clang-1103.0.32.53) Target: x86_64-apple-macosx10.13 [Makefile] sites/* => build/macosx-x86_64-apple-macosx10.13/apps => ~/Applications/MacPin.localized/*.app Jumbo-execs: build/macosx-x86_64-apple-macosx10.13/lexec/MacPin Jumbo-deps: build/macosx-x86_64-apple-macosx10.13/obj/libPrompt.a build/macosx-x86_64-apple-macosx10.13/obj/libUTIKit.a Jumbo-lib: build/macosx-x86_64-apple-macosx10.13/Frameworks/MacPin.framework /Applications/Safari.app => 13.1.2 /System/Library/Frameworks/WebKit.framework => 15609.3.5.1.3 make: Circular sites/DevDocs <- build/macosx-x86_64-apple-macosx10.13/apps/DevDocs.app dependency dropped. Apple Swift version 5.2.4 (swiftlang-1103.0.32.9 clang-1103.0.32.53) Target: x86_64-apple-macosx10.13 /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift -frontend -c modules/MacPin/App.swift modules/MacPin/AppDelegate.swift modules/MacPin/AppScriptRuntime.swift modules/MacPin/BrowserViewController.swift modules/MacPin/CocoaShims.swift modules/MacPin/FavIcon.swift modules/MacPin/Generics.swift modules/MacPin/Geolocator.swift modules/MacPin/Prompter.swift modules/MacPin/Retriever.swift modules/MacPin/TabFlowController.swift modules/MacPin/WebNotifier.swift modules/MacPin/WebView.swift modules/MacPin/WebViewCallbacks.swift modules/MacPin/WebViewController.swift modules/MacPin/WebViewDelegates.swift modules/MacPin/_macos/AppDelegateOSX.swift modules/MacPin/_macos/BrowserViewControllerOSX.swift modules/MacPin/_macos/EffectViewController.swift modules/MacPin/_macos/FoundationExts.swift modules/MacPin/_macos/OmniBoxController.swift modules/MacPin/_macos/Services.swift modules/MacPin/_macos/StatusBarController.swift modules/MacPin/_macos/WebViewControllerOSX.swift modules/MacPin/_macos/WebViewDelegatesOSX.swift modules/MacPin/_macos/WindowController.swift -supplementary-output-file-map /var/folders/9g/g6tf7dm93ln55szbqsvty2j00000gs/T/supplementaryOutputs-c0b761 -target x86_64-apple-macosx10.13 -enable-objc-interop -sdk /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -color-diagnostics -I modules -I /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/System/Library/Frameworks -I build/macosx-x86_64-apple-macosx10.13 -F build/macosx-x86_64-apple-macosx10.13/Frameworks -F /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/System/Library/Frameworks -suppress-warnings -swift-version 5 -color-diagnostics -Xcc -Wno-unreachable-code -parse-as-library -module-name MacPin -o /var/folders/9g/g6tf7dm93ln55szbqsvty2j00000gs/T/MacPin-c28baf.o modules/MacPin/WebView.swift:1307:27: error: 'rects(forCharacterRange:)' is only available in macOS 10.15 or newer guard let frects = self.rects(forCharacterRange: range), ^ modules/MacPin/WebView.swift:1307:27: note: add 'if #available' version check guard let frects = self.rects(forCharacterRange: range), ^ modules/MacPin/WebView.swift:1304:22: note: add @available attribute to enclosing instance method @objc override func scrollRangeToVisible(_ range: NSRange) { ^ modules/MacPin/WebView.swift:1285:1: note: add @available attribute to enclosing extension extension MPWebView { // NSTextFinderClient ^ modules/MacPin/WebView.swift:1312:9: error: 'scrollRangeToVisible' is only available in macOS 10.15 or newer super.scrollRangeToVisible(range) ^ modules/MacPin/WebView.swift:1312:9: note: add 'if #available' version check super.scrollRangeToVisible(range) ^ modules/MacPin/WebView.swift:1304:22: note: add @available attribute to enclosing instance method @objc override func scrollRangeToVisible(_ range: NSRange) { ^ modules/MacPin/WebView.swift:1285:1: note: add @available attribute to enclosing extension extension MPWebView { // NSTextFinderClient ^ make: *** [build/macosx-x86_64-apple-macosx10.13/obj/libMacPin.dylib] Error 1 ```
kfix commented 2 years ago

wontfix. 10.15 is now the target OSX version (minimum)