search

kfix / MacPin

a webapp container & site specific browser made from WebKit.swift and JavaScriptCore
GNU General Public License v3.0
331 stars 27 forks source link

CMD + H, CMD + M Don't Work (Trello) #7

Closed joshdickson closed 8 years ago

joshdickson commented 8 years ago

Hey, great project.

Should shortcuts be working?

Also, header shows up as black which looks sort of weird.

Not a Mac dev myself or I'd put in a PR, but thought I'd at least bring to your attn.

kfix commented 8 years ago

I could implement ⌘+M to minimize. ⌘+H is a bit less straightforward...there are no static Home pages or bookmarks in MacPin apps, only an initial tab and "Shortcuts". Perhaps first shortcut made should always be ⌘+H?

The header is like FaceTime for Hacker/Dark Mode reasons and auto-hides in full screen (disabling minimize). Could make it a toggle.

joshdickson commented 8 years ago

⌘+H I'm implying to be 'hide', not home (Which I think is what you're referring to? Not sure). I did notice there is no 'hide' implemented so it's not just the shortcut that doesn't work.

Both are fairly standard for Mac apps, everything I use has them. Makes it hard to remember which one application doesn't have it implemented ;P

I do have dark mode enabled on Mac OS X, but Safari is always light so it looks sort of off. Would be great to have a toggle.

Thanks.