search

kfl / mosml

Moscow ML is a light-weight implementation of Standard ML (SML), a strict functional language widely used in teaching and research.
http://mosml.org
341 stars 42 forks source link

Fixed compilation of webserver example. #40

Closed const-rs closed 8 years ago

const-rs commented 8 years ago

Webserver example does not compile without this tiny fix.

kfl commented 8 years ago

Thanks, nice catch.

(BTW, you might also be interested in https://github.com/kfl/webserver-functor)

const-rs commented 8 years ago

Thanks. Why don't you want to merge pull request with Size exception in Time?

kfl commented 8 years ago

I do want to merge PR #38, but since it is a change to a basic library module. I want to make sure that it doesn't break anything, and preferably add a unit test for it. Alas, I haven't had time to do that (or rather, when I've had time, I've forgotten.)

const-rs commented 8 years ago

Great! I actually was afraid that you have abandoned the project. I am currently writing a .mlb parser (mosmlb tool). It is almost correctly is parsing all MLton .mlb files. I'll send pull request not intended for merge today (for discussion).

kfl commented 8 years ago

In that case you might be interested in https://github.com/kfl/mosml/tree/master/src/mosmlpm which was my attempt at implementing a predecessor for .mlb files.

const-rs commented 8 years ago

Thanks! I used it as a start. :-)