kfl / staffeli_nt

Staffeli NT Technology
MIT License
8 stars 8 forks source link

possible fix for #22 #27

Closed Spatenheinz closed 3 years ago

Spatenheinz commented 3 years ago

i have made a suggestion for a fix for issue #22, it is a bit hacky in smoe places but it should work. the ta file will be a yaml with format ta: -kuid -kuid

etc.

madsobitsoe commented 3 years ago

This works exactly as I want it to. Nice!

I would be fine with merging it in - but maybe that's why I don't have the power to actually merge it in.

There are however som new issues based on this:

So, I propose merging this and adding new issues:

  1. Add the same feature but targeted at group submissions
  2. "Make main in download.py readable and sane(r)"
  3. Add documentation/usage strings
Spatenheinz commented 3 years ago
1. Add the same feature but targeted at group submissions

It should work for groups with the caveat that all members of a particular group should be in the list so i agree the code should maybe be a bit more robust

2. "Make main in download.py readable and sane(r)"
3. Add documentation/usage strings

I agree on these.

madsobitsoe commented 3 years ago

Jacob is right, it works with groups. My tests were bad.