Closed Spatenheinz closed 3 years ago
This works exactly as I want it to. Nice!
I would be fine with merging it in - but maybe that's why I don't have the power to actually merge it in.
There are however som new issues based on this:
We should really either redo the way we parse arguments, or stick to the really strict way of just indexing into argv. Currently the COURSEID, grading template and destination dir are argv[1], 2 and 3, while --select-section and --select-ta file.yaml are searched for. It is a bit of a mess to read through main in download.py
This fix, i.e. my idea, only works for individual assignments. Individual assignments is where we'll have the largest need for it anyway. For group assignments, we won't get the groups but one directory per student. (Obvious when you think about it, not when I came up with the idea).
So, I propose merging this and adding new issues:
1. Add the same feature but targeted at group submissions
It should work for groups with the caveat that all members of a particular group should be in the list so i agree the code should maybe be a bit more robust
2. "Make main in download.py readable and sane(r)" 3. Add documentation/usage strings
I agree on these.
Jacob is right, it works with groups. My tests were bad.
i have made a suggestion for a fix for issue #22, it is a bit hacky in smoe places but it should work. the ta file will be a yaml with format ta: -kuid -kuid
etc.