search

kfl / staffeli_nt

Staffeli NT Technology
MIT License
8 stars 8 forks source link

Support for tasks with no points #41

Closed Cavtheman closed 2 years ago

Cavtheman commented 2 years ago

Small quality of life change that allows templates to exclude a points field for tasks. Suitable for general comments or bonus tasks that don't affect the overall grade. grade.yml files can now look like this:

- Assignment1General:
      feedback: |
          [*] You should spell check your assignments before handing them in.
          [-] You did not include a zip-file with code, please upload.

Instead of this:

- Assignment1General:
      grade:
      points: 0
      feedback: |
          [*] You should spell check your assignments before handing them in.
          [-] You did not include a zip-file with code, please upload.

This means that people grading don't need to input points to tasks with 0 points.

kfl commented 2 years ago

Thank you for the PR.

It looks good.

(The only tiny nit is that it would have nice to get the "delete-trailing-whitespace" changes in a separate commit. Just to make it easier to review the changes.)

Cavtheman commented 2 years ago

Oh. Oops, didn't realise I did that.

kfl commented 2 years ago

It is not a big problem. And I'm certainly happy that the trailing whitespace got deleted.