kfl / staffeli_nt

Staffeli NT Technology
MIT License
8 stars 7 forks source link

Distribute.py script which generates a ta_list.yml file for use by download.py #42

Open Cavtheman opened 2 years ago

Cavtheman commented 2 years ago

The implementation currently has two modes:

Known bugs:

Potential improvements:

kfl commented 2 years ago

Thanks a lot for your PR.

However, I'll not merge this PR in its current state:

If you have difficulties fixing any of these points, feel free to either ask questions here or drop by my office.

It seems that staffeli_nt might have a longer lifespan than the two weeks I originally intended it to have. Thus, I want to maintain a minimal repo hygiene.

By the way, may I ask for which course you are using it?

Cavtheman commented 2 years ago

I've convinced the professor and other TAs to use it in Elements of Machine Learning. I know Sofie has also convinced the TAs in Softwareudvikling to use it

Cavtheman commented 2 years ago

I have made a feature branch named "distribute", but I don't think I can change the base of the pull request? I think that it should clean up the commit log.

kfl commented 2 years ago

It seems that you have added the --no-unzip code to this PR as well.

kfl commented 2 years ago

I have made a feature branch named "distribute", but I don't think I can change the base of the pull request? I think that it should clean up the commit log.

I think you have to make a new PR if you want to change branch. A PR literally means a Request to Pull from a specific branch.