search

kfl / staffeli_nt

Staffeli NT Technology
MIT License
8 stars 7 forks source link

Submission comments with emoji crash Staffeli on windows #58

Open madsobitsoe opened 2 years ago

madsobitsoe commented 2 years ago

If a student has used Emoji in a submission comment, and the host platform is windows, Staffeli will crash with a UnicodeException, as the emoji values are not defined in the windows charset(s).

Great fun, so happy I added the download-comments feature.

The crash happens when writing the comments to disk.

Suggestion for fix:

  1. Strip submission-comments for non-ascii values
  2. Catch exceptions when writing, potentially print "Sorry, comment is too pretty to save to disk"

Suggestion 2 is by far the easiest.

kfl commented 1 year ago

I think this is fixed now.

But need somebody with Windows access to confirm.