kfl / staffeli_nt

Staffeli NT Technology
MIT License
8 stars 7 forks source link

run_onlineTA makes very specific assumptions on submission structure #63

Open madsobitsoe opened 1 year ago

madsobitsoe commented 1 year ago

The code currently expects a submission to

It also unpacks the submitted zip-file and re-zips it before sending it to online_ta as code.zip.

These assumptions are iirc. from PoP2021. I believe they should be removed.

The good thing about unzipping and rezipping is that we avoid submitting "junk" by cleaning up the students handins first. The con of that, is that we hide the students' errors from them. It's a choice between "making stuff work" and reporting errors.

I suggest we either add another function or clean up the one we already have. The filename of the rezipped file should be the same as the submitted zip-file. (Or just use the submitted zip-file, although that will cause a lot fewer PoP-submissions to go through onlineTA successfully).

https://github.com/kfl/staffeli_nt/blob/6b088f669faf7f35b6ccd10ff6fcca3c93d4cf0e/staffeli_nt/util.py#L9