kfogel / OneTime

An open source encryption program that uses the "one-time pad" method.
http://red-bean.com/onetime
32 stars 14 forks source link

Make Prefix Specification #11

Closed DomT4 closed 8 years ago

DomT4 commented 10 years ago

Can OneTime be changed to fit make prefix specification?

Currently if you wish to change where it does make install you have to edit the makefile, but this isn't terribly convenient from the command line.

Would it be possible to move towards

make install DESTDIR=#{prefix}

or

make install prefix=#{prefix}

instead?

kfogel commented 10 years ago

Dominyk Tiller notifications@github.com writes:

Can OneTime be changed to fit make prefix specification?

Currently if you wish to change where it does make install you have to edit the makefile, but this isn't terribly convenient from the command line.

Would it be possible to move towards

make install DESTDIR=#{prefix}

or

make install prefix=#{prefix}

instead?

I'd be okay with that. Can you write the patch and submit it as (as a patch or as a pull request, whichever is more convient for you)?

Best, -Karl

DomT4 commented 9 years ago

Extremely belatedly, I have created a PR to fix this.

kfogel commented 9 years ago

Thanks! I see the PR in issue #12, and have commented there about the reason for my delay in responding.