kframework / k-legacy

The K tools (deprecated, see README)
http://kframework.org
Other
146 stars 61 forks source link

Sentence order is not remembered in modules #1831

Open bmmoore opened 9 years ago

bmmoore commented 9 years ago

Sentence order is pretty random because Module keeps a Set and we use hash sets everywhere. Conversion to scala sets is fairly localized, but tons of code makes a HashSet on the Java side as part of their processing too, so even if the scala implementation of Module was adjusted we would already be forgetting order in tons of places.

cos commented 9 years ago

Brandon and I decided to postpone this for a bit until we have a stable naming convention. We can then use order sentences lexicographically based on their name. See #1833.