search

kframework / kweb

Online extensible IDE for the K Framework and other formal verification projects. Example deployment at http://kframework.org/kweb/
5 stars 5 forks source link

integrated javamop into kweb #18

Closed kheradmand closed 9 years ago

kheradmand commented 10 years ago

@pdaian @grosu I added minimum necessary functionally to kweb for supporting javamop. I must confess that this is not a clean solution. I first started making clean generalizations for supporting both javamop and k (and possibility other projects) in clean way. But after spending 2 days, I realized that it is really a waste of time at this stage. So I ignored those and added minimum required changes to support javamop in addition to k. We can refactor the code later when we have more time.

grosu commented 10 years ago

OK, let't first get it to work with javamop as we want to, and then we refactor to have one implementation for both, with just a simple configuration to switch to one or the other.

If you want me to give you any feedback, I'll need a working web interface posted on the web, so I can play with it.

Thanks, Grigore

From: Ali Kheradmand [notifications@github.com] Sent: Monday, November 03, 2014 6:06 AM To: kframework/kweb Cc: Rosu, Grigore Subject: [kweb] integrated javamop into kweb (#18)

@pdaianhttps://github.com/pdaian @grosuhttps://github.com/grosu I added minimum necessary functionally to kweb for supporting javamop. I must confess that this is not a clean solution. I first started making clean generalizations for supporting both javamop and k (and possibility other projects) in clean way. But after spending 2 days, I realized that it is really a waste of time at this stage. So I ignored those and added minimum required changes to support javamop in addition to k. We can refactor the code later when we have more time.

You can merge this Pull Request by running

git pull https://github.com/kheradmand/kweb master

Or view, comment on, or merge it at:

https://github.com/kframework/kweb/pull/18

Commit Summary

File Changes

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/kframework/kweb/pull/18.

kheradmand commented 10 years ago

@grosu I do not have enough permissions I guess. @pdaian Can you deploy it?

pdaian commented 10 years ago

@grosu @kheradmand I will be working on this. It may take me a day or so as the version of kweb on fslweb is not exactly the version of kweb in Git (because fslweb runs a very old version of Linux which both K and Python have all sorts of issues with), so I need to resolve a few conflicts and also formalize and clean up all the deployment time changes on fslweb.

Thanks for the work @kheradmand , it looks great! (I wish the diff were a little smaller, but we'll get there soon :))

@grosu - Ali already did the work to run K and JavaMOP on a single online interface. The generalization stuff he's referring to means generalization of the code to allow cleaner addition of future tools, and is invisible to the user. Currently kweb will get an extra dropdown under tools that says "JavaMOP" with the JavaMOP examples and executables.

tl;dr - Git on fslweb's kweb deployment is out of sync and I need to resolve merge conflicts. ETA 1 day.

pdaian commented 9 years ago

@grosu @kheradmand sorry for the delay on this, got caught up in the Toyota deliverable. I know this may be blocking for JavaMOP, so it's the first thing I will work on after the deliverable is due on Friday (should be done over the weekend). Will keep you both up to date. Thanks.

kheradmand commented 9 years ago

@pdaian thanks a lot Philip :) Grigore had some suggestions on what I did and I thought it would be better to wait until you merge the pull request and then make more commits.