kfrancis / chargify-dot-net

MIT License
20 stars 49 forks source link

Number/DateTime parsing routines MUST use invariant (or otherwise explicit) culture #28

Closed LordJZ closed 8 years ago

LordJZ commented 8 years ago

JSON spec explicitly states which characters can be used to denote numbers; Chargify also uses culture-independent settings when outputting JSON and XML. However, chargify-dot-net uses the current thread culture to parse numbers and dates/times both in JSON and XML, and sometimes fails silently when failing to parse JSON or XML.

Tests can be used to enforce 3 conditions:

Incomplete list of affected methods:

LordJZ commented 8 years ago

Why is this closed though? There are still tons of issues unsolved.